From: kbuild test robot <lkp@intel.com>
To: Jan Kara <jack@suse.cz>
Cc: kbuild-all@01.org, linux-ext4@vger.kernel.org,
Ted Tso <tytso@mit.edu>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 17/19] jbd2: Rename h_buffer_credits to h_total_credits
Date: Mon, 30 Sep 2019 20:26:27 +0800 [thread overview]
Message-ID: <201909302058.uxNSY0q3%lkp@intel.com> (raw)
In-Reply-To: <20190930104339.24919-17-jack@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 5998 bytes --]
Hi Jan,
I love your patch! Yet something to improve:
[auto build test ERROR on ext4/dev]
[cannot apply to v5.3 next-20190930]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Jan-Kara/ext4-Fix-transaction-overflow-due-to-revoke-descriptors/20190930-184615
base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: x86_64-randconfig-a004-201939 (attached as .config)
compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/jbd2/transaction.c: In function 'jbd2_journal_start_reserved':
>> fs/jbd2/transaction.c:596:20: error: 'handle_t {aka struct jbd2_journal_handle}' has no member named 'h_buffer_credits'
line_no, handle->h_buffer_credits);
^
vim +596 fs/jbd2/transaction.c
8f7d89f36829b9 Jan Kara 2013-06-04 546
8f7d89f36829b9 Jan Kara 2013-06-04 547 /**
f69120ce6c024a Tobin C. Harding 2018-01-10 548 * int jbd2_journal_start_reserved() - start reserved handle
8f7d89f36829b9 Jan Kara 2013-06-04 549 * @handle: handle to start
f69120ce6c024a Tobin C. Harding 2018-01-10 550 * @type: for handle statistics
f69120ce6c024a Tobin C. Harding 2018-01-10 551 * @line_no: for handle statistics
8f7d89f36829b9 Jan Kara 2013-06-04 552 *
8f7d89f36829b9 Jan Kara 2013-06-04 553 * Start handle that has been previously reserved with jbd2_journal_reserve().
8f7d89f36829b9 Jan Kara 2013-06-04 554 * This attaches @handle to the running transaction (or creates one if there's
8f7d89f36829b9 Jan Kara 2013-06-04 555 * not transaction running). Unlike jbd2_journal_start() this function cannot
8f7d89f36829b9 Jan Kara 2013-06-04 556 * block on journal commit, checkpointing, or similar stuff. It can block on
8f7d89f36829b9 Jan Kara 2013-06-04 557 * memory allocation or frozen journal though.
8f7d89f36829b9 Jan Kara 2013-06-04 558 *
8f7d89f36829b9 Jan Kara 2013-06-04 559 * Return 0 on success, non-zero on error - handle is freed in that case.
8f7d89f36829b9 Jan Kara 2013-06-04 560 */
8f7d89f36829b9 Jan Kara 2013-06-04 561 int jbd2_journal_start_reserved(handle_t *handle, unsigned int type,
8f7d89f36829b9 Jan Kara 2013-06-04 562 unsigned int line_no)
8f7d89f36829b9 Jan Kara 2013-06-04 563 {
8f7d89f36829b9 Jan Kara 2013-06-04 564 journal_t *journal = handle->h_journal;
8f7d89f36829b9 Jan Kara 2013-06-04 565 int ret = -EIO;
8f7d89f36829b9 Jan Kara 2013-06-04 566
8f7d89f36829b9 Jan Kara 2013-06-04 567 if (WARN_ON(!handle->h_reserved)) {
8f7d89f36829b9 Jan Kara 2013-06-04 568 /* Someone passed in normal handle? Just stop it. */
8f7d89f36829b9 Jan Kara 2013-06-04 569 jbd2_journal_stop(handle);
8f7d89f36829b9 Jan Kara 2013-06-04 570 return ret;
8f7d89f36829b9 Jan Kara 2013-06-04 571 }
8f7d89f36829b9 Jan Kara 2013-06-04 572 /*
8f7d89f36829b9 Jan Kara 2013-06-04 573 * Usefulness of mixing of reserved and unreserved handles is
8f7d89f36829b9 Jan Kara 2013-06-04 574 * questionable. So far nobody seems to need it so just error out.
8f7d89f36829b9 Jan Kara 2013-06-04 575 */
8f7d89f36829b9 Jan Kara 2013-06-04 576 if (WARN_ON(current->journal_info)) {
8f7d89f36829b9 Jan Kara 2013-06-04 577 jbd2_journal_free_reserved(handle);
8f7d89f36829b9 Jan Kara 2013-06-04 578 return ret;
8f7d89f36829b9 Jan Kara 2013-06-04 579 }
8f7d89f36829b9 Jan Kara 2013-06-04 580
8f7d89f36829b9 Jan Kara 2013-06-04 581 handle->h_journal = NULL;
8f7d89f36829b9 Jan Kara 2013-06-04 582 /*
8f7d89f36829b9 Jan Kara 2013-06-04 583 * GFP_NOFS is here because callers are likely from writeback or
8f7d89f36829b9 Jan Kara 2013-06-04 584 * similarly constrained call sites
8f7d89f36829b9 Jan Kara 2013-06-04 585 */
8f7d89f36829b9 Jan Kara 2013-06-04 586 ret = start_this_handle(journal, handle, GFP_NOFS);
92e3b405377070 Dan Carpenter 2014-02-17 587 if (ret < 0) {
b2569260d55228 Theodore Ts'o 2018-04-18 588 handle->h_journal = journal;
8f7d89f36829b9 Jan Kara 2013-06-04 589 jbd2_journal_free_reserved(handle);
92e3b405377070 Dan Carpenter 2014-02-17 590 return ret;
92e3b405377070 Dan Carpenter 2014-02-17 591 }
8f7d89f36829b9 Jan Kara 2013-06-04 592 handle->h_type = type;
8f7d89f36829b9 Jan Kara 2013-06-04 593 handle->h_line_no = line_no;
4c273352bb4583 Xiaoguang Wang 2019-08-24 594 trace_jbd2_handle_start(journal->j_fs_dev->bd_dev,
4c273352bb4583 Xiaoguang Wang 2019-08-24 595 handle->h_transaction->t_tid, type,
4c273352bb4583 Xiaoguang Wang 2019-08-24 @596 line_no, handle->h_buffer_credits);
92e3b405377070 Dan Carpenter 2014-02-17 597 return 0;
8f7d89f36829b9 Jan Kara 2013-06-04 598 }
8f7d89f36829b9 Jan Kara 2013-06-04 599 EXPORT_SYMBOL(jbd2_journal_start_reserved);
470decc613ab20 Dave Kleikamp 2006-10-11 600
:::::: The code at line 596 was first introduced by commit
:::::: 4c273352bb4583750bf511fe24fe410610414496 jbd2: add missing tracepoint for reserved handle
:::::: TO: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
:::::: CC: Theodore Ts'o <tytso@mit.edu>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34766 bytes --]
next prev parent reply other threads:[~2019-09-30 12:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 10:43 [PATCH 0/19 v2] ext4: Fix transaction overflow due to revoke descriptors Jan Kara
2019-09-30 10:43 ` [PATCH 01/19] jbd2: Fix possible overflow in jbd2_log_space_left() Jan Kara
2019-09-30 10:43 ` [PATCH 02/19] jbd2: Fixup stale comment in commit code Jan Kara
2019-09-30 10:43 ` [PATCH 03/19] ext4: Do not iput inode under running transaction in ext4_mkdir() Jan Kara
2019-09-30 10:43 ` [PATCH 04/19] ext4: Use ext4_journal_extend() instead of jbd2_journal_extend() Jan Kara
2019-09-30 10:43 ` [PATCH 05/19] ext4: Avoid unnecessary revokes in ext4_alloc_branch() Jan Kara
2019-09-30 10:43 ` [PATCH 06/19] ext4: Provide function to handle transaction restarts Jan Kara
2019-09-30 10:43 ` [PATCH 07/19] ext4, jbd2: Provide accessor function for handle credits Jan Kara
2019-09-30 10:43 ` [PATCH 08/19] ocfs2: Use accessor function for h_buffer_credits Jan Kara
2019-09-30 10:43 ` [PATCH 09/19] jbd2: Fix statistics for the number of logged blocks Jan Kara
2019-09-30 10:43 ` [PATCH 10/19] jbd2: Reorganize jbd2_journal_stop() Jan Kara
2019-09-30 10:43 ` [PATCH 11/19] jbd2: Drop pointless check from jbd2_journal_stop() Jan Kara
2019-09-30 10:43 ` [PATCH 12/19] jbd2: Drop pointless wakeup " Jan Kara
2019-09-30 10:43 ` [PATCH 13/19] jbd2: Factor out common parts of stopping and restarting a handle Jan Kara
2019-09-30 10:43 ` [PATCH 14/19] jbd2: Account descriptor blocks into t_outstanding_credits Jan Kara
2019-09-30 10:43 ` [PATCH 15/19] jbd2: Drop jbd2_space_needed() Jan Kara
2019-09-30 10:43 ` [PATCH 16/19] jbd2: Reserve space for revoke descriptor blocks Jan Kara
2019-09-30 12:24 ` kbuild test robot
2019-09-30 10:43 ` [PATCH 17/19] jbd2: Rename h_buffer_credits to h_total_credits Jan Kara
2019-09-30 11:27 ` kbuild test robot
2019-09-30 12:26 ` kbuild test robot [this message]
2019-09-30 15:05 ` Theodore Y. Ts'o
2019-09-30 16:25 ` Jan Kara
2019-09-30 21:21 ` Theodore Y. Ts'o
2019-10-01 7:59 ` Jan Kara
2019-10-03 8:33 ` Jan Kara
2019-10-03 13:29 ` Theodore Y. Ts'o
2019-10-03 21:50 ` Jan Kara
2019-09-30 10:43 ` [PATCH 18/19] jbd2: Make credit checking more strict Jan Kara
2019-09-30 10:43 ` [PATCH 19/19] ext4: Reserve revoke credits for freed blocks Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201909302058.uxNSY0q3%lkp@intel.com \
--to=lkp@intel.com \
--cc=jack@suse.cz \
--cc=kbuild-all@01.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).