From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7AE9C47404 for ; Wed, 9 Oct 2019 10:42:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B512D2133F for ; Wed, 9 Oct 2019 10:42:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mbobrowski-org.20150623.gappssmtp.com header.i=@mbobrowski-org.20150623.gappssmtp.com header.b="I8aIhyJ8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729942AbfJIKmb (ORCPT ); Wed, 9 Oct 2019 06:42:31 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:41904 "EHLO mail-pl1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729566AbfJIKmb (ORCPT ); Wed, 9 Oct 2019 06:42:31 -0400 Received: by mail-pl1-f181.google.com with SMTP id t10so859046plr.8 for ; Wed, 09 Oct 2019 03:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Bm58YBswdlISkDr/Ri9rK9T+YxLaZyKmJp4DGvcJTBg=; b=I8aIhyJ8I7eXY+MUGOunHtMn6yXr1flIzb64UdLjR6f4S4S4HW8P+ydbg8Mb5x771M gfFVAxGILf6ALC5vbppKVpqPeMUBIYR/HzP4TRvu7eU2b/3QdGcpB3Zxdg5pmyUHSS40 pG1/gNBxuLT7YP6uFqNm6lJ6oSB2mO/t8svE5FpbAxxxYqkFXSb6GVI96UPQ0B2cKLZX wjiGJ5q4MCR5Ad6C14cQA1Bn9quHwGmphku24TcrlJLffYjbrwqhk5R0Jj5SAqQnXh7C gOA/Yu39oCaUbjKNNjevJxzyhs21oJ8a28wh98pu49VvKNANvtGMG4aEv1+52Lvywoqd Janw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Bm58YBswdlISkDr/Ri9rK9T+YxLaZyKmJp4DGvcJTBg=; b=OaQGE8jldMomNwCtLaC1bchScMufyJMeAbwmXXgLcOPFhY+E5dyHHVs5JfYMin+0Uc pIv4KSwyC5iIdEcKeAu5RoyXo+edBMvmpU6a4bygBNerAiRh8gHzmQHWppuoL/1wTQgd IArdMqBKuRYXpvPdX+EqNKGBdsS3ylNJKXDQ+4YQYaW/YEAz65ZkA4BwytOa6BboBvuf 8d+Lxf5eOFnrbyhMoGja6HZJtUJS1+s7LX4eWtzi/5dSO5eRRHtTORGuW68HSYEjF/NN fbEjDgjv67TL9PENUivBQ+Q9f23dMlTU0RZhQlMAdbB8VqjYM0lvNSnKVbNXug06GZio F3BA== X-Gm-Message-State: APjAAAUmGXLfFu1crub7zrV5WDOdPzVF1+Tdxe/QgQZocujHWEhIIG6m gGBcxN1PIUvzqBsUpUR8PQ0U X-Google-Smtp-Source: APXvYqxN69Tjyhd5JrhDTftfgmmWiJND0nFIpMG9lopTpbZTDjnDe4p+ppTyjeoIFhyMtSomAzn2fQ== X-Received: by 2002:a17:902:930b:: with SMTP id bc11mr2488108plb.284.1570617748885; Wed, 09 Oct 2019 03:42:28 -0700 (PDT) Received: from poseidon.bobrowski.net ([114.78.226.167]) by smtp.gmail.com with ESMTPSA id f128sm1955760pfg.143.2019.10.09.03.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 03:42:28 -0700 (PDT) Date: Wed, 9 Oct 2019 21:42:22 +1100 From: Matthew Bobrowski To: Jan Kara Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH v4 7/8] ext4: reorder map.m_flags checks in ext4_set_iomap() Message-ID: <20191009104220.GD14749@poseidon.bobrowski.net> References: <3551610e53aa1984210a4de04ad6e1a89f5bf0a3.1570100361.git.mbobrowski@mbobrowski.org> <20191008113012.GJ5078@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191008113012.GJ5078@quack2.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Oct 08, 2019 at 01:30:12PM +0200, Jan Kara wrote: > The patch looks good to me. You can add: > > Reviewed-by: Jan Kara Thanks Jan! > Just those 72 columns limited comment lines... ;) *nod* - will be fixed! ----