From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] iomap: iomap that extends beyond EOF should be marked dirty
Date: Tue, 15 Oct 2019 23:40:33 -0700 [thread overview]
Message-ID: <20191016064033.GA18326@infradead.org> (raw)
In-Reply-To: <20191016052713.GX13108@magnolia>
On Tue, Oct 15, 2019 at 10:27:13PM -0700, Darrick J. Wong wrote:
> > + /*
> > + * Writes that span EOF might trigger an IO size update on completion,
> > + * so consider them to be dirty for the purposes of O_DSYNC even if
> > + * there is no other metadata changes being made or are pending here.
> > + */
> > + if (offset + count > i_size_read(inode))
> > + iomap->flags |= IOMAP_F_DIRTY;
>
> This ought to be in xfs_direct_write_iomap_begin(), right?
>
> (Hoping to see another rev of Christoph's iomap cleanup series... ;))
I need to finish off all the nitpicks on the first iomap series..
Also we'll want this patch in first as it is 5.4 / -stable material,
so I'll need to rebase on top of that as well.
next prev parent reply other threads:[~2019-10-16 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 5:11 [PATCH] iomap: iomap that extends beyond EOF should be marked dirty Dave Chinner
2019-10-16 5:25 ` Dave Chinner
2019-10-16 5:27 ` Darrick J. Wong
2019-10-16 6:40 ` Christoph Hellwig [this message]
2019-10-16 6:06 ` [PATCH v2] " Dave Chinner
2019-10-16 6:43 ` Christoph Hellwig
2019-10-17 12:29 ` Theodore Y. Ts'o
2019-10-17 14:17 ` Christoph Hellwig
2019-10-17 14:48 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016064033.GA18326@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).