linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: jack@suse.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] ext2: don't set *count in the case of failure in ext2_try_to_allocate()
Date: Wed, 30 Oct 2019 11:15:11 +0100	[thread overview]
Message-ID: <20191030101511.GA28525@quack2.suse.cz> (raw)
In-Reply-To: <20191026090721.23794-1-cgxu519@mykernel.net>

On Sat 26-10-19 17:07:21, Chengguang Xu wrote:
> Currently we set *count to num(value 0) in the failure
> of block allocation in ext2_try_to_allocate(). Without
> reservation, we reuse *count(value 0) to retry block
> allocation and wrong *count will cause only allocating
> maximum 1 block even though having sufficent free blocks
> in that block group. Finally, it probably cause significant
> fragmentation.
> 
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>

Thanks! Patch applied.

								Honza

> ---
> v1->v2:
> - Add detail explanation of effect to changelog.
> 
>  fs/ext2/balloc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
> index e0cc55164505..29fc3a5054f8 100644
> --- a/fs/ext2/balloc.c
> +++ b/fs/ext2/balloc.c
> @@ -736,7 +736,6 @@ ext2_try_to_allocate(struct super_block *sb, int group,
>  	*count = num;
>  	return grp_goal - num;
>  fail_access:
> -	*count = num;
>  	return -1;
>  }
>  
> -- 
> 2.21.0
> 
> 
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

      reply	other threads:[~2019-10-30 10:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-26  9:07 [PATCH v2] ext2: don't set *count in the case of failure in ext2_try_to_allocate() Chengguang Xu
2019-10-30 10:15 ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191030101511.GA28525@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=cgxu519@mykernel.net \
    --cc=jack@suse.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).