From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Olof Johansson <olof@lixom.net>, tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] fs: ext4: remove unused variable warning in parse_options()
Date: Tue, 12 Nov 2019 21:53:39 +0530 [thread overview]
Message-ID: <20191112162341.E3F334204C@d06av24.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <20191111022523.34256-1-olof@lixom.net>
On 11/11/19 7:55 AM, Olof Johansson wrote:
> Commit c33fbe8f673c5 ("ext4: Enable blocksize < pagesize for
> dioread_nolock") removed the only user of 'sbi' outside of the ifdef,
> so it caused a new warning:
>
> fs/ext4/super.c:2068:23: warning: unused variable 'sbi' [-Wunused-variable]
>
> Fixes: c33fbe8f673c5 ("ext4: Enable blocksize < pagesize for dioread_nolock")
> Signed-off-by: Olof Johansson <olof@lixom.net>
hmm, I see that I had CONFIG_QUOTA enabled, so missed this.
Thanks for the patch.
You may add:
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
> ---
> fs/ext4/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index f3279210f0ba9..ee8c42d8a04f0 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2065,7 +2065,7 @@ static int parse_options(char *options, struct super_block *sb,
> unsigned int *journal_ioprio,
> int is_remount)
> {
> - struct ext4_sb_info *sbi = EXT4_SB(sb);
> + struct ext4_sb_info __maybe_unused *sbi = EXT4_SB(sb);
> char *p, __maybe_unused *usr_qf_name, __maybe_unused *grp_qf_name;
> substring_t args[MAX_OPT_ARGS];
> int token;
>
next prev parent reply other threads:[~2019-11-12 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 2:25 [PATCH] fs: ext4: remove unused variable warning in parse_options() Olof Johansson
2019-11-12 16:23 ` Ritesh Harjani [this message]
2019-11-14 22:59 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112162341.E3F334204C@d06av24.portsmouth.uk.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).