From: Eric Biggers <ebiggers@kernel.org>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@lists.01.org,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
syzbot+f8d6f8386ceacdbfff57@syzkaller.appspotmail.com,
stable@kernel.org
Subject: Re: [PATCH -v2] ext4: add more paranoia checking in ext4_expand_extra_isize handling
Date: Mon, 18 Nov 2019 18:15:26 -0800 [thread overview]
Message-ID: <20191119021526.GB3147@sol.localdomain> (raw)
In-Reply-To: <20191110121510.GH23325@mit.edu>
On Sun, Nov 10, 2019 at 07:15:10AM -0500, Theodore Y. Ts'o wrote:
> I hadn't gotten around to resending the patch. The original version
> had a number of last-minute typos that had crept in...
>
> - Ted
>
> From a67ad537964d10f94a4b990c084365e75316cde8 Mon Sep 17 00:00:00 2001
> From: Theodore Ts'o <tytso@mit.edu>
> Date: Thu, 7 Nov 2019 21:43:41 -0500
> Subject: [PATCH] ext4: add more paranoia checking in ext4_expand_extra_isize
> handling
>
>
> It's possible to specify a non-zero s_want_extra_isize via debugging
> option, and this can cause bad things(tm) to happen when using a file
> system with an inode size of 128 bytes.
>
> Add better checking when the file system is mounted, as well as when
> we are actually doing the trying to do the inode expansion.
>
> Reported-by: syzbot+f8d6f8386ceacdbfff57@syzkaller.appspotmail.com
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Cc: stable@kernel.org
Is this patch intended to address
https://lore.kernel.org/linux-ext4/000000000000950f21059564e4c7@google.com
as well? If so, you can add the second Reported-by line so that both syzbot
reports get closed.
- Eric
next prev parent reply other threads:[~2019-11-19 2:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 2:48 [PATCH] ext4: add more paranoia checking in ext4_expand_extra_isize handling Theodore Ts'o
2019-11-10 10:12 ` kbuild test robot
2019-11-10 12:15 ` [PATCH -v2] " Theodore Y. Ts'o
2019-11-19 2:15 ` Eric Biggers [this message]
2019-11-19 4:21 ` Theodore Y. Ts'o
2019-11-19 4:36 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119021526.GB3147@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-ext4@vger.kernel.org \
--cc=lkp@intel.com \
--cc=stable@kernel.org \
--cc=syzbot+f8d6f8386ceacdbfff57@syzkaller.appspotmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).