Re: [PATCH v4 linux-kselftest-test 5/6] kunit: allow kunit to be loaded as a module

From: Stephen Boyd <sboyd@kernel.org>
To: Alan Maguire <alan.maguire@oracle.com>,
	brendanhiggins@google.com, linux-kselftest@vger.kernel.org,
	skhan@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com,
	keescook@chromium.org, yzaikin@google.com,
	akpm@linux-foundation.org, yamada.masahiro@socionext.com,
	catalin.marinas@arm.com, joe.lawrence@redhat.com,
	penguin-kernel@i-love.sakura.ne.jp, schowdary@nvidia.com,
	urezki@gmail.com, andriy.shevchenko@linux.intel.com,
	corbet@lwn.net, tytso@mit.edu, adilger.kernel@dilger.ca,
	mcgrof@kernel.org, changbin.du@intel.com,
	linux-ext4@vger.kernel.org, linux-doc@vger.kernel.org,
	Alan Maguire <alan.maguire@oracle.com>,
	Knut Omang <knut.omang@oracle.com>
Subject: Re: [PATCH v4 linux-kselftest-test 5/6] kunit: allow kunit to be loaded as a module
Date: Tue, 19 Nov 2019 13:13:14 -0800	[thread overview]
Message-ID: <20191119211315.4EFC6223E4@mail.kernel.org> (raw)
In-Reply-To: <1573812972-10529-6-git-send-email-alan.maguire@oracle.com>

Quoting Alan Maguire (2019-11-15 02:16:11)
> diff --git a/lib/kunit/test.c b/lib/kunit/test.c
> index 87b5cf1..41ef71a 100644
> --- a/lib/kunit/test.c
> +++ b/lib/kunit/test.c
> @@ -486,3 +486,16 @@ void kunit_cleanup(struct kunit *test)
>         }
>  }
>  EXPORT_SYMBOL_GPL(kunit_cleanup);
> +
> +static int kunit_init(void)

Missing __init?

> +{
> +       return 0;
> +}
> +late_initcall(kunit_init);

It looks pretty weird that this doesn't do anything in the module init
or exit path. How does it work? And why does it need to be late init if
nothing is called from here?

> +
> +static void __exit kunit_exit(void)
> +{
> +}
> +module_exit(kunit_exit);
> +
> +MODULE_LICENSE("GPL");

I guess should be "GPL v2"?