Linux-ext4 Archive on lore.kernel.org
 help / color / Atom feed
* [Resend PATCH] ext2: set proper errno in error case of ext2_fill_super()
@ 2019-11-29  1:36 Chengguang Xu
  2019-11-29  9:48 ` Jan Kara
  0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2019-11-29  1:36 UTC (permalink / raw)
  To: jack; +Cc: linux-ext4, Chengguang Xu

Set proper errno in the case of failure of
initializing percpu variables.

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
Forgot to cc ext4 maillist, so resend it.

 fs/ext2/super.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 30c630d73f0f..74a9e3e71c13 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1147,6 +1147,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
 				ext2_count_dirs(sb), GFP_KERNEL);
 	}
 	if (err) {
+		ret = err;
 		ext2_msg(sb, KERN_ERR, "error: insufficient memory");
 		goto failed_mount3;
 	}
-- 
2.20.1




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Resend PATCH] ext2: set proper errno in error case of ext2_fill_super()
  2019-11-29  1:36 [Resend PATCH] ext2: set proper errno in error case of ext2_fill_super() Chengguang Xu
@ 2019-11-29  9:48 ` Jan Kara
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2019-11-29  9:48 UTC (permalink / raw)
  To: Chengguang Xu; +Cc: jack, linux-ext4

On Fri 29-11-19 09:36:36, Chengguang Xu wrote:
> Set proper errno in the case of failure of
> initializing percpu variables.
> 
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>

Thanks. I've added the patch to my tree.

								Honza

> ---
> Forgot to cc ext4 maillist, so resend it.
> 
>  fs/ext2/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 30c630d73f0f..74a9e3e71c13 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1147,6 +1147,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
>  				ext2_count_dirs(sb), GFP_KERNEL);
>  	}
>  	if (err) {
> +		ret = err;
>  		ext2_msg(sb, KERN_ERR, "error: insufficient memory");
>  		goto failed_mount3;
>  	}
> -- 
> 2.20.1
> 
> 
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29  1:36 [Resend PATCH] ext2: set proper errno in error case of ext2_fill_super() Chengguang Xu
2019-11-29  9:48 ` Jan Kara

Linux-ext4 Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ext4/0 linux-ext4/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ext4 linux-ext4/ https://lore.kernel.org/linux-ext4 \
		linux-ext4@vger.kernel.org
	public-inbox-index linux-ext4

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ext4


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git