From: kbuild test robot <lkp@intel.com>
To: Daniel Rosenberg <drosen@google.com>
Cc: kbuild-all@lists.01.org, Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <chao@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>,
kernel-team@android.com, Daniel Rosenberg <drosen@google.com>
Subject: Re: [PATCH 5/8] f2fs: Handle casefolding with Encryption
Date: Thu, 5 Dec 2019 09:17:15 +0800 [thread overview]
Message-ID: <201912050955.3f2DMo5g%lkp@intel.com> (raw)
In-Reply-To: <20191203051049.44573-6-drosen@google.com>
Hi Daniel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on next-20191202 next-20191204]
[cannot apply to ext4/dev f2fs/dev-test v5.4 v5.4-rc8 v5.4-rc7 v5.4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Daniel-Rosenberg/Support-for-Casefolding-and-Encryption/20191203-131410
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 76bb8b05960c3d1668e6bee7624ed886cbd135ba
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-91-g817270f-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/f2fs/dir.c:205:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected int len @@ got restricted __le16 [usertyint len @@
>> fs/f2fs/dir.c:205:13: sparse: expected int len
fs/f2fs/dir.c:205:13: sparse: got restricted __le16 [usertype] name_len
--
>> fs/f2fs/hash.c:90:27: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] f2fs_hash @@ got __le32 [usertype] f2fs_hash @@
>> fs/f2fs/hash.c:90:27: sparse: expected restricted __le32 [usertype] f2fs_hash
>> fs/f2fs/hash.c:90:27: sparse: got unsigned long long
fs/f2fs/hash.c:133:24: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted __le32 @@ got e32 @@
fs/f2fs/hash.c:133:24: sparse: expected restricted __le32
fs/f2fs/hash.c:133:24: sparse: got int
fs/f2fs/hash.c:141:11: sparse: sparse: incorrect type in assignment (different base types) @@ expected int r @@ got restricted __int r @@
fs/f2fs/hash.c:141:11: sparse: expected int r
fs/f2fs/hash.c:141:11: sparse: got restricted __le32
fs/f2fs/hash.c:144:16: sparse: sparse: incorrect type in return expression (different base types) @@ expected restricted __le32 @@ got le32 @@
fs/f2fs/hash.c:144:16: sparse: expected restricted __le32
fs/f2fs/hash.c:144:16: sparse: got int r
vim +205 fs/f2fs/dir.c
199
200 if (de->hash_code != namehash)
201 return false;
202
203 #ifdef CONFIG_UNICODE
204 name = d->filename[bit_pos];
> 205 len = de->name_len;
206
207 if (sb->s_encoding && needs_casefold(parent)) {
208 if (cf_str->name) {
209 struct qstr cf = {.name = cf_str->name,
210 .len = cf_str->len};
211 return !f2fs_ci_compare(parent, &cf, name, len, true);
212 }
213 return !f2fs_ci_compare(parent, fname->usr_fname, name, len,
214 false);
215 }
216 #endif
217 if (fscrypt_match_name(fname, d->filename[bit_pos],
218 le16_to_cpu(de->name_len)))
219 return true;
220 return false;
221 }
222
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
next prev parent reply other threads:[~2019-12-05 1:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 5:10 [PATCH 0/8] Support for Casefolding and Encryption Daniel Rosenberg
2019-12-03 5:10 ` [PATCH 1/8] fscrypt: Add siphash and hash key for policy v2 Daniel Rosenberg
2019-12-03 23:25 ` Eric Biggers
2019-12-03 5:10 ` [PATCH 2/8] fscrypt: Don't allow v1 policies with casefolding Daniel Rosenberg
2019-12-03 23:37 ` Eric Biggers
2019-12-03 5:10 ` [PATCH 3/8] fscrypt: Change format of no-key token Daniel Rosenberg
2019-12-04 0:09 ` Eric Biggers
2019-12-03 5:10 ` [PATCH 4/8] vfs: Fold casefolding into vfs Daniel Rosenberg
2019-12-03 7:41 ` Gao Xiang
2019-12-03 19:42 ` Gabriel Krisman Bertazi
2019-12-03 20:34 ` Eric Biggers
2019-12-03 21:21 ` Gabriel Krisman Bertazi
2019-12-04 0:32 ` Eric Biggers
2019-12-03 19:31 ` Gabriel Krisman Bertazi
2020-01-03 20:26 ` Theodore Y. Ts'o
2019-12-03 5:10 ` [PATCH 5/8] f2fs: Handle casefolding with Encryption Daniel Rosenberg
2019-12-05 1:17 ` kbuild test robot [this message]
2019-12-03 5:10 ` [PATCH 6/8] ext4: Use struct super_block's casefold data Daniel Rosenberg
2019-12-03 19:44 ` Gabriel Krisman Bertazi
2019-12-03 5:10 ` [PATCH 7/8] ext4: Hande casefolding with encryption Daniel Rosenberg
2019-12-03 5:10 ` [PATCH 8/8] ext4: Optimize match for casefolded encrypted dirs Daniel Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201912050955.3f2DMo5g%lkp@intel.com \
--to=lkp@intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=chao@kernel.org \
--cc=corbet@lwn.net \
--cc=drosen@google.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kernel-team@android.com \
--cc=krisman@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).