From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49835C2D0BF for ; Tue, 10 Dec 2019 09:16:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2624B2073B for ; Tue, 10 Dec 2019 09:16:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727007AbfLJJQe (ORCPT ); Tue, 10 Dec 2019 04:16:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:52708 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726975AbfLJJQe (ORCPT ); Tue, 10 Dec 2019 04:16:34 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AE8CFABC7; Tue, 10 Dec 2019 09:16:32 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 302EE1E0B23; Tue, 10 Dec 2019 10:16:32 +0100 (CET) Date: Tue, 10 Dec 2019 10:16:32 +0100 From: Jan Kara To: Randy Dunlap Cc: Linux FS Devel , linux-ext4@vger.kernel.org, Theodore Ts'o , Jan Kara Subject: Re: [PATCH] jbd2: fix kernel-doc notation warning Message-ID: <20191210091632.GB1551@quack2.suse.cz> References: <53e3ce27-ceae-560d-0fd4-f95728a33e12@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53e3ce27-ceae-560d-0fd4-f95728a33e12@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun 08-12-19 20:31:32, Randy Dunlap wrote: > From: Randy Dunlap > > Fix kernel-doc warning by inserting a beginning '*' character > for the kernel-doc line. > > ../include/linux/jbd2.h:461: warning: bad line: journal. These are dirty buffers and revoke descriptor blocks. > > Signed-off-by: Randy Dunlap > Cc: "Theodore Ts'o" > Cc: Jan Kara > Cc: linux-ext4@vger.kernel.org Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > include/linux/jbd2.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20191209.orig/include/linux/jbd2.h > +++ linux-next-20191209/include/linux/jbd2.h > @@ -457,7 +457,7 @@ struct jbd2_revoke_table_s; > * @h_journal: Which journal handle belongs to - used iff h_reserved set. > * @h_rsv_handle: Handle reserved for finishing the logical operation. > * @h_total_credits: Number of remaining buffers we are allowed to add to > - journal. These are dirty buffers and revoke descriptor blocks. > + * journal. These are dirty buffers and revoke descriptor blocks. > * @h_revoke_credits: Number of remaining revoke records available for handle > * @h_ref: Reference count on this handle. > * @h_err: Field for caller's use to track errors through large fs operations. > -- Jan Kara SUSE Labs, CR