From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 054FEC282DD for ; Thu, 9 Jan 2020 17:24:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5B60206ED for ; Thu, 9 Jan 2020 17:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731672AbgAIRY4 (ORCPT ); Thu, 9 Jan 2020 12:24:56 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:33824 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728444AbgAIRY4 (ORCPT ); Thu, 9 Jan 2020 12:24:56 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-111.corp.google.com [104.133.0.111] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 009HOpHk031966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 9 Jan 2020 12:24:52 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 846494207DF; Thu, 9 Jan 2020 12:24:51 -0500 (EST) Date: Thu, 9 Jan 2020 12:24:51 -0500 From: "Theodore Y. Ts'o" To: Jan Kara Cc: Ext4 Developers List Subject: Re: [PATCH] ext4: export information about first/last errors via /sys/fs/ext4/ Message-ID: <20200109172451.GD33929@mit.edu> References: <20191224000541.88473-1-tytso@mit.edu> <20200109091240.GA27035@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109091240.GA27035@quack2.suse.cz> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jan 09, 2020 at 10:12:40AM +0100, Jan Kara wrote: > On Mon 23-12-19 19:05:41, Theodore Ts'o wrote: > > Make {first,last}_error_{ino,block,line,func,errcode} available via > > sysfs. > > > > Also add a missing newline for {first,last}_error_time. > > > > Signed-off-by: Theodore Ts'o > > The patch looks good to me. You can add: > > Reviewed-by: Jan Kara > > I'm just wondering a bit why do you need this? Some system monitoring > thing? Yes, precisely. Especially in cloud environments, where the disk often gets deleted when the VM is terminated, so reading the this information from the superblock won't be possible. - Ted