linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Anatoly Pugachev <matorola@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] libext2fs: Extends commit c9a8c53b, with the same fix for ext2fs_flush2() and ext2fs_image_super_write() on a Big Endian systems.
Date: Fri, 10 Jan 2020 12:34:32 -0500	[thread overview]
Message-ID: <20200110173432.GB304349@mit.edu> (raw)
In-Reply-To: <20200110085217.GA7307@yogzotot>

On Fri, Jan 10, 2020 at 11:52:17AM +0300, Anatoly Pugachev wrote:
> 
> libext2fs: extends commit c9a8c53b, with the same fix for ext2fs_flush2() and
> ext2fs_image_super_write() on a Big Endian systems.
> 
> As follow-up to previous discussion 'dumpe2fs / mke2fs sigserv on sparc64'
> 
> Used find for files which refer to:
> 
> e2fsprogs.git$ find . -name \*.c | xargs grep -cl 'gdp = ext2fs_group_desc'
> ./lib/ext2fs/closefs.c
> ./lib/ext2fs/openfs.c
> ./lib/ext2fs/imager.c
> 
> And applied the same check for a null pointer.
> 
> Tested on a debian linux with sparc64 LDOM and ppc64 LPAR.
> 
> Fixes sigserv with test suite in "i_bitmaps" test.

As far as I know, the i_bitmaps test is passing on on sparc64 and
ppc64.  Search for i_bitmaps in:

https://buildd.debian.org/status/fetch.php?pkg=e2fsprogs&arch=sparc64&ver=1.45.5-2&stamp=1578527938&raw=0
   and
https://buildd.debian.org/status/fetch.php?pkg=e2fsprogs&arch=ppc64&ver=1.45.5-2&stamp=1578526270&raw=0

The bug in c9a8c53b was caused by SPARSE_SUPER being passed to
ext2fs_open().  But that doesn't happen in misc/e2image.

I can see optimizing ext2fs_flush() to skip byte-swapping the group
descriptors if the SUPER_ONLY flag is enabled.  And I can see
ext2fs_image_super_write() checking to see if the SUPER_ONLY flag is
set, and returning an error in that case.

But I don't think any of the current e2fsprogs are crashing at the
moment.  Am I missing something?

Regards,

					- Ted

  reply	other threads:[~2020-01-10 17:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  8:52 [PATCH] libext2fs: Extends commit c9a8c53b, with the same fix for ext2fs_flush2() and ext2fs_image_super_write() on a Big Endian systems Anatoly Pugachev
2020-01-10 17:34 ` Theodore Y. Ts'o [this message]
2020-01-11  0:13   ` Anatoly Pugachev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200110173432.GB304349@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=matorola@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).