Linux-ext4 Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ext4: remove unnecessary selections from EXT3_FS
@ 2019-12-26 15:39 Eric Biggers
  2020-01-09 10:19 ` Jan Kara
  2020-01-13 19:17 ` Theodore Y. Ts'o
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2019-12-26 15:39 UTC (permalink / raw)
  To: linux-ext4

From: Eric Biggers <ebiggers@google.com>

Since EXT3_FS already selects EXT4_FS, there's no reason for it to
redundantly select all the selections of EXT4_FS -- notwithstanding the
comments that claim otherwise.

Remove these redundant selections to avoid confusion.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/ext4/Kconfig | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
index ef42ab040905..5841fd8aa706 100644
--- a/fs/ext4/Kconfig
+++ b/fs/ext4/Kconfig
@@ -4,12 +4,7 @@
 # kernels after the removal of ext3 driver.
 config EXT3_FS
 	tristate "The Extended 3 (ext3) filesystem"
-	# These must match EXT4_FS selects...
 	select EXT4_FS
-	select JBD2
-	select CRC16
-	select CRYPTO
-	select CRYPTO_CRC32C
 	help
 	  This config option is here only for backward compatibility. ext3
 	  filesystem is now handled by the ext4 driver.
@@ -33,7 +28,6 @@ config EXT3_FS_SECURITY
 
 config EXT4_FS
 	tristate "The Extended 4 (ext4) filesystem"
-	# Please update EXT3_FS selects when changing these
 	select JBD2
 	select CRC16
 	select CRYPTO
-- 
2.24.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ext4: remove unnecessary selections from EXT3_FS
  2019-12-26 15:39 [PATCH] ext4: remove unnecessary selections from EXT3_FS Eric Biggers
@ 2020-01-09 10:19 ` Jan Kara
  2020-01-13 19:17 ` Theodore Y. Ts'o
  1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2020-01-09 10:19 UTC (permalink / raw)
  To: Eric Biggers; +Cc: linux-ext4

On Thu 26-12-19 09:39:20, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> Since EXT3_FS already selects EXT4_FS, there's no reason for it to
> redundantly select all the selections of EXT4_FS -- notwithstanding the
> comments that claim otherwise.
> 
> Remove these redundant selections to avoid confusion.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Interesting. I was always thinking that 'select' is not recursive - at
least that's how I was interpretting the note in kconfig-language.rs:

  Note:
        select should be used with care. select will force
        a symbol to a value without visiting the dependencies.
        By abusing select you are able to select a symbol FOO even
        if FOO depends on BAR that is not set.
        In general use select only for non-visible symbols
        (no prompts anywhere) and for symbols with no dependencies.
        That will limit the usefulness but on the other hand avoid
        the illegal configurations all over.

But when experimenting with it now, I agree that these additional selects
don't seem to be needed in ext3 config. So probably the paragraph just
references to the fact that 'depends on' dependencies are not checked for
'select'. All in all this is a long way to say:

Reviewed-by: Jan Kara <jack@suse.cz>

:)
								Honza

> ---
>  fs/ext4/Kconfig | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
> index ef42ab040905..5841fd8aa706 100644
> --- a/fs/ext4/Kconfig
> +++ b/fs/ext4/Kconfig
> @@ -4,12 +4,7 @@
>  # kernels after the removal of ext3 driver.
>  config EXT3_FS
>  	tristate "The Extended 3 (ext3) filesystem"
> -	# These must match EXT4_FS selects...
>  	select EXT4_FS
> -	select JBD2
> -	select CRC16
> -	select CRYPTO
> -	select CRYPTO_CRC32C
>  	help
>  	  This config option is here only for backward compatibility. ext3
>  	  filesystem is now handled by the ext4 driver.
> @@ -33,7 +28,6 @@ config EXT3_FS_SECURITY
>  
>  config EXT4_FS
>  	tristate "The Extended 4 (ext4) filesystem"
> -	# Please update EXT3_FS selects when changing these
>  	select JBD2
>  	select CRC16
>  	select CRYPTO
> -- 
> 2.24.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ext4: remove unnecessary selections from EXT3_FS
  2019-12-26 15:39 [PATCH] ext4: remove unnecessary selections from EXT3_FS Eric Biggers
  2020-01-09 10:19 ` Jan Kara
@ 2020-01-13 19:17 ` Theodore Y. Ts'o
  1 sibling, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2020-01-13 19:17 UTC (permalink / raw)
  To: Eric Biggers; +Cc: linux-ext4

On Thu, Dec 26, 2019 at 09:39:20AM -0600, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> Since EXT3_FS already selects EXT4_FS, there's no reason for it to
> redundantly select all the selections of EXT4_FS -- notwithstanding the
> comments that claim otherwise.
> 
> Remove these redundant selections to avoid confusion.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Applied, thanks.

					- Ted

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-26 15:39 [PATCH] ext4: remove unnecessary selections from EXT3_FS Eric Biggers
2020-01-09 10:19 ` Jan Kara
2020-01-13 19:17 ` Theodore Y. Ts'o

Linux-ext4 Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ext4/0 linux-ext4/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ext4 linux-ext4/ https://lore.kernel.org/linux-ext4 \
		linux-ext4@vger.kernel.org
	public-inbox-index linux-ext4

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ext4


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git