From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] fscrypt: optimize fscrypt_zeroout_range()
Date: Mon, 13 Jan 2020 14:31:09 -0500 [thread overview]
Message-ID: <20200113193109.GB76141@mit.edu> (raw)
In-Reply-To: <20191226160813.53182-1-ebiggers@kernel.org>
On Thu, Dec 26, 2019 at 10:08:13AM -0600, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Currently fscrypt_zeroout_range() issues and waits on a bio for each
> block it writes, which makes it very slow.
>
> Optimize it to write up to 16 pages at a time instead.
>
> Also add a function comment, and improve reliability by allowing the
> allocations of the bio and the first ciphertext page to wait on the
> corresponding mempools.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Looks good, feel free to add:
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
next prev parent reply other threads:[~2020-01-13 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 16:08 [PATCH] fscrypt: optimize fscrypt_zeroout_range() Eric Biggers
2020-01-13 19:31 ` Theodore Y. Ts'o [this message]
2020-01-14 20:53 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113193109.GB76141@mit.edu \
--to=tytso@mit.edu \
--cc=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).