Linux-ext4 Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] fs/ext4: remove MPAGE_DA_EXTENT_TAIL
@ 2020-01-15  9:51 Alex Shi
  2020-01-15 10:12 ` Jan Kara
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Shi @ 2020-01-15  9:51 UTC (permalink / raw)
  To: unlisted-recipients:; (no To-header on input)
  Cc: Theodore Ts'o, Jan Kara, Andreas Dilger, linux-ext4, linux-kernel

After commit 4e7ea81db534 ("ext4: restructure writeback path"), this
macro isn't used anymore. so better to remove it.

Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: "Theodore Ts'o" <tytso@mit.edu> 
Cc: Jan Kara <jack@suse.cz>
Cc: Andreas Dilger <adilger.kernel@dilger.ca> 
Cc: linux-ext4@vger.kernel.org 
Cc: linux-kernel@vger.kernel.org 
---
 fs/ext4/inode.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 629a25d999f0..bb2d8c9205b7 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -48,8 +48,6 @@
 
 #include <trace/events/ext4.h>
 
-#define MPAGE_DA_EXTENT_TAIL 0x01
-
 static __u32 ext4_inode_csum(struct inode *inode, struct ext4_inode *raw,
 			      struct ext4_inode_info *ei)
 {
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fs/ext4: remove MPAGE_DA_EXTENT_TAIL
  2020-01-15  9:51 [PATCH] fs/ext4: remove MPAGE_DA_EXTENT_TAIL Alex Shi
@ 2020-01-15 10:12 ` Jan Kara
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2020-01-15 10:12 UTC (permalink / raw)
  To: Alex Shi
  Cc: Theodore Ts'o, Jan Kara, Andreas Dilger, linux-ext4, linux-kernel

On Wed 15-01-20 17:51:28, Alex Shi wrote:
> After commit 4e7ea81db534 ("ext4: restructure writeback path"), this
> macro isn't used anymore. so better to remove it.
> 
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: "Theodore Ts'o" <tytso@mit.edu> 
> Cc: Jan Kara <jack@suse.cz>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca> 
> Cc: linux-ext4@vger.kernel.org 
> Cc: linux-kernel@vger.kernel.org 

Thanks for the patch but I think Ted already merged a very similar cleanup
into his tree.

								Honza

> ---
>  fs/ext4/inode.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 629a25d999f0..bb2d8c9205b7 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -48,8 +48,6 @@
>  
>  #include <trace/events/ext4.h>
>  
> -#define MPAGE_DA_EXTENT_TAIL 0x01
> -
>  static __u32 ext4_inode_csum(struct inode *inode, struct ext4_inode *raw,
>  			      struct ext4_inode_info *ei)
>  {
> -- 
> 1.8.3.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15  9:51 [PATCH] fs/ext4: remove MPAGE_DA_EXTENT_TAIL Alex Shi
2020-01-15 10:12 ` Jan Kara

Linux-ext4 Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ext4/0 linux-ext4/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ext4 linux-ext4/ https://lore.kernel.org/linux-ext4 \
		linux-ext4@vger.kernel.org
	public-inbox-index linux-ext4

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ext4


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git