From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1963C33CB1 for ; Wed, 15 Jan 2020 10:17:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0C4C206D7 for ; Wed, 15 Jan 2020 10:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729638AbgAOKRL (ORCPT ); Wed, 15 Jan 2020 05:17:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:53868 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729585AbgAOKRL (ORCPT ); Wed, 15 Jan 2020 05:17:11 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 13B11ABC7; Wed, 15 Jan 2020 10:17:08 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 26E6B1E0CBC; Wed, 15 Jan 2020 11:12:04 +0100 (CET) Date: Wed, 15 Jan 2020 11:12:04 +0100 From: Jan Kara To: Alex Shi Cc: Theodore Ts'o , Jan Kara , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/ext4: remove MPAGE_DA_EXTENT_TAIL Message-ID: <20200115101204.GD31450@quack2.suse.cz> References: <1579081888-6244-1-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1579081888-6244-1-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed 15-01-20 17:51:28, Alex Shi wrote: > After commit 4e7ea81db534 ("ext4: restructure writeback path"), this > macro isn't used anymore. so better to remove it. > > Signed-off-by: Alex Shi > Cc: "Theodore Ts'o" > Cc: Jan Kara > Cc: Andreas Dilger > Cc: linux-ext4@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Thanks for the patch but I think Ted already merged a very similar cleanup into his tree. Honza > --- > fs/ext4/inode.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 629a25d999f0..bb2d8c9205b7 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -48,8 +48,6 @@ > > #include > > -#define MPAGE_DA_EXTENT_TAIL 0x01 > - > static __u32 ext4_inode_csum(struct inode *inode, struct ext4_inode *raw, > struct ext4_inode_info *ei) > { > -- > 1.8.3.1 > -- Jan Kara SUSE Labs, CR