From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] mmp: abstract out repeated 'sizeof(buf), buf' usage
Date: Sat, 25 Jan 2020 01:43:56 -0500 [thread overview]
Message-ID: <20200125064356.GB1108497@mit.edu> (raw)
In-Reply-To: <1579038138-49231-2-git-send-email-adilger@dilger.ca>
On Tue, Jan 14, 2020 at 02:42:18PM -0700, Andreas Dilger wrote:
> The printf("%.*s") format requires both the buffer size and buffer
> pointer to be specified for each use. Since this is repeatedly given
> as "(int)sizeof(buf), (char *)buf" for mmp_nodename and mmp_bdevname
> fields, with typecasts to avoid compiler warnings.
>
> Add a helper macro EXT2_LEN_STR() to avoid repeated boilerplate code.
>
> This can also be used for other superblock buffer fields that may not
> have NUL-terminated strings (e.g. s_volume_name, s_last_mounted,
> s_{first,last}_error_func, s_mount_opts) to simplify code and avoid
> the need for temporary buffers for NUL-termination.
>
> Annotate the superblock string fields that may not be NUL-terminated.
>
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2020-01-25 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 22:07 Inconsistent use of string/non_strings in mmp_struct Theodore Y. Ts'o
2020-01-07 23:35 ` Andreas Dilger
2020-01-14 21:42 ` [PATCH 1/2] mmp: don't assume NUL termination for MMP strings Andreas Dilger
2020-01-14 21:42 ` [PATCH 2/2] mmp: abstract out repeated 'sizeof(buf), buf' usage Andreas Dilger
2020-01-25 6:43 ` Theodore Y. Ts'o [this message]
2020-01-25 6:43 ` [PATCH 1/2] mmp: don't assume NUL termination for MMP strings Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200125064356.GB1108497@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).