From: Jan Kara <jack@suse.cz>
To: "zhangyi (F)" <yi.zhang@huawei.com>
Cc: jack@suse.cz, tytso@mit.edu, linux-ext4@vger.kernel.org,
luoshijie1@huawei.com, zhangxiaoxu5@huawei.com
Subject: Re: [PATCH 1/2] jbd2: move the clearing of b_modified flag to the journal_unmap_buffer()
Date: Thu, 6 Feb 2020 12:03:35 +0100 [thread overview]
Message-ID: <20200206110335.GA3994@quack2.suse.cz> (raw)
In-Reply-To: <20200203140458.37397-2-yi.zhang@huawei.com>
On Mon 03-02-20 22:04:57, zhangyi (F) wrote:
> There is no need to delay the clearing of b_modified flag to the
> transaction committing time when unmapping the journalled buffer, so
> just move it to the journal_unmap_buffer().
>
> Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Thanks for the patch. It looks good, just one small comment below:
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index e77a5a0b4e46..a479cbf8ae54 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -2337,11 +2337,7 @@ static int journal_unmap_buffer(journal_t *journal, struct buffer_head *bh,
> set_buffer_freed(bh);
> if (journal->j_running_transaction && buffer_jbddirty(bh))
> jh->b_next_transaction = journal->j_running_transaction;
> - spin_unlock(&journal->j_list_lock);
> - spin_unlock(&jh->b_state_lock);
> - write_unlock(&journal->j_state_lock);
> - jbd2_journal_put_journal_head(jh);
> - return 0;
> + may_free = 0;
I'd rather add b_modified clearing here than trying to reuse the tail of
the function. Because this condition is different from the other ones that
end up in zap_buffer_locked - here we really want to keep bh and jh mostly
intact.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-02-06 11:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 14:04 [PATCH 0/2] jbd2: fix an oops problem zhangyi (F)
2020-02-03 14:04 ` [PATCH 1/2] jbd2: move the clearing of b_modified flag to the journal_unmap_buffer() zhangyi (F)
2020-02-06 11:03 ` Jan Kara [this message]
2020-02-03 14:04 ` [PATCH 2/2] jbd2: do not clear the BH_Mapped flag when forgetting a metadata buffer zhangyi (F)
2020-02-06 11:46 ` Jan Kara
2020-02-06 15:28 ` zhangyi (F)
2020-02-12 8:45 ` Jan Kara
2020-02-11 6:51 ` zhangyi (F)
2020-02-12 8:47 ` Jan Kara
2020-02-12 13:14 ` zhangyi (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206110335.GA3994@quack2.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=luoshijie1@huawei.com \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).