From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32EC1C3F2CD for ; Fri, 28 Feb 2020 14:08:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A27F24680 for ; Fri, 28 Feb 2020 14:08:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726811AbgB1OIh (ORCPT ); Fri, 28 Feb 2020 09:08:37 -0500 Received: from mx2.suse.de ([195.135.220.15]:52506 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbgB1OIh (ORCPT ); Fri, 28 Feb 2020 09:08:37 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 28C0DB12A; Fri, 28 Feb 2020 14:08:35 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id B21DCDA7FF; Fri, 28 Feb 2020 15:08:14 +0100 (CET) Date: Fri, 28 Feb 2020 15:08:14 +0100 From: David Sterba To: Christoph Hellwig Cc: Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH v8 17/25] btrfs: Convert from readpages to readahead Message-ID: <20200228140814.GK2902@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org References: <20200225214838.30017-1-willy@infradead.org> <20200225214838.30017-18-willy@infradead.org> <20200226170507.GC22837@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226170507.GC22837@infradead.org> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Feb 26, 2020 at 09:05:07AM -0800, Christoph Hellwig wrote: > On Tue, Feb 25, 2020 at 01:48:30PM -0800, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > Implement the new readahead method in btrfs. Add a readahead_page_batch() > > to optimise fetching a batch of pages at once. > > readahead_page_batch() isn't added in this patch anymore. > > Otherwise this looks good to me, although I don't feel confident > enough to give a Reviewed-by for btrfs code. Review is on my todo so the series is not blocked on that.