From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Ritesh Harjani <riteshh@linux.ibm.com>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz, tytso@mit.edu,
adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org,
hch@infradead.org, cmaiolino@redhat.com, david@fromorbit.com
Subject: Re: [PATCHv5 3/6] ext4: Move ext4 bmap to use iomap infrastructure.
Date: Fri, 28 Feb 2020 07:25:24 -0800 [thread overview]
Message-ID: <20200228152524.GE8036@magnolia> (raw)
In-Reply-To: <8bbd53bd719d5ccfecafcce93f2bf1d7955a44af.1582880246.git.riteshh@linux.ibm.com>
On Fri, Feb 28, 2020 at 02:56:56PM +0530, Ritesh Harjani wrote:
> ext4_iomap_begin is already implemented which provides ext4_map_blocks,
> so just move the API from generic_block_bmap to iomap_bmap for iomap
> conversion.
>
> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> ---
> fs/ext4/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 6cf3b969dc86..81fccbae0aea 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3214,7 +3214,7 @@ static sector_t ext4_bmap(struct address_space *mapping, sector_t block)
> return 0;
> }
>
> - return generic_block_bmap(mapping, block, ext4_get_block);
> + return iomap_bmap(mapping, block, &ext4_iomap_ops);
/me notes that iomap_bmap will filemap_write_and_wait for you, so one
could optimize ext4_bmap to avoid the double-flush by moving the
filemap_write_and_wait at the top of the function into the JDATA state
clearing block.
OTOH it's bmap, who cares... :)
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> }
>
> static int ext4_readpage(struct file *file, struct page *page)
> --
> 2.21.0
>
next prev parent reply other threads:[~2020-02-28 15:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 9:26 [PATCHv5 0/6] ext4: bmap & fiemap conversion to use iomap Ritesh Harjani
2020-02-28 9:26 ` [PATCHv5 1/6] ext4: Add IOMAP_F_MERGED for non-extent based mapping Ritesh Harjani
2020-02-28 15:26 ` Darrick J. Wong
2020-03-13 19:52 ` Theodore Y. Ts'o
2020-02-28 9:26 ` [PATCHv5 2/6] ext4: Optimize ext4_ext_precache for 0 depth Ritesh Harjani
2020-03-13 20:05 ` Theodore Y. Ts'o
2020-02-28 9:26 ` [PATCHv5 3/6] ext4: Move ext4 bmap to use iomap infrastructure Ritesh Harjani
2020-02-28 15:25 ` Darrick J. Wong [this message]
2020-03-02 8:58 ` Ritesh Harjani
2020-03-03 15:47 ` Darrick J. Wong
2020-03-04 12:42 ` Jan Kara
2020-03-04 15:37 ` Darrick J. Wong
2020-03-07 2:32 ` Theodore Y. Ts'o
2020-03-06 17:49 ` Ritesh Harjani
2020-03-07 0:51 ` Darrick J. Wong
2020-03-07 5:50 ` Ritesh Harjani
2020-03-13 20:16 ` Theodore Y. Ts'o
2020-02-28 9:26 ` [PATCHv5 4/6] ext4: Make ext4_ind_map_blocks work with fiemap Ritesh Harjani
2020-03-13 20:18 ` Theodore Y. Ts'o
2020-02-28 9:26 ` [PATCHv5 5/6] ext4: Move ext4_fiemap to use iomap framework Ritesh Harjani
2020-02-28 15:21 ` Darrick J. Wong
2020-03-14 3:03 ` Theodore Y. Ts'o
2020-02-28 9:26 ` [PATCHv5 6/6] Documentation: Correct the description of FIEMAP_EXTENT_LAST Ritesh Harjani
2020-02-28 15:20 ` Darrick J. Wong
2020-02-28 15:36 ` Matthew Wilcox
2020-03-02 8:10 ` Ritesh Harjani
2020-03-14 3:48 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228152524.GE8036@magnolia \
--to=darrick.wong@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=cmaiolino@redhat.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).