From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Eric Sandeen <sandeen@sandeen.net>, linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, jack@suse.cz, adilger.kernel@dilger.ca,
linux-fsdevel@vger.kernel.org,
Harish Sriram <harish@linux.ibm.com>
Subject: Re: [PATCH] ext4: Check for non-zero journal inum in ext4_calculate_overhead
Date: Thu, 19 Mar 2020 10:06:38 +0530 [thread overview]
Message-ID: <20200319043639.C505752050@d06av21.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <c43090c0-ce45-0737-68a5-ffe3e362012e@sandeen.net>
On 3/18/20 11:57 PM, Eric Sandeen wrote:
> On 3/16/20 4:30 AM, Ritesh Harjani wrote:
>> While calculating overhead for internal journal, also check
>> that j_inum shouldn't be 0. Otherwise we get below error with
>> xfstests generic/050 with external journal (XXX_LOGDEV config) enabled.
>>
>> It could be simply reproduced with loop device with an external journal
>> and marking blockdev as RO before mounting.
>>
>> [ 3337.146838] EXT4-fs error (device pmem1p2): ext4_get_journal_inode:4634: comm mount: inode #0: comm mount: iget: illegal inode #
>> ------------[ cut here ]------------
>> generic_make_request: Trying to write to read-only block-device pmem1p2 (partno 2)
>
> I think this 2nd error comes from:
>
> static void save_error_info(struct super_block *sb, const char *func,
> unsigned int line)
> {
> __save_error_info(sb, func, line);
> ext4_commit_super(sb, 1);
> }
>
> __save_error_info() returns if bdev_read_only() but then we try to commit the super
> anyway. Shouldn't save_error_info() return early if bdev_read_only()?
>
> (that'd be a separate patch, I'll send it)
Thanks. Sounds good to me.
>
> -Eric
>
next prev parent reply other threads:[~2020-03-19 4:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 9:30 [PATCH] ext4: Check for non-zero journal inum in ext4_calculate_overhead Ritesh Harjani
2020-03-17 11:17 ` Jan Kara
2020-03-18 18:27 ` Eric Sandeen
2020-03-19 4:36 ` Ritesh Harjani [this message]
2020-03-24 1:52 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319043639.C505752050@d06av21.portsmouth.uk.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=harish@linux.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).