From: Eric Biggers <ebiggers@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Theodore Ts'o <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <yuchao0@huawei.com>
Subject: Re: [f2fs-dev] Fwd: Add page_cache_readahead_unbounded
Date: Fri, 20 Mar 2020 08:49:47 -0700 [thread overview]
Message-ID: <20200320154947.GA851@sol.localdomain> (raw)
In-Reply-To: <20200320142932.GA4971@bombadil.infradead.org>
Hi Matthew,
On Fri, Mar 20, 2020 at 07:29:32AM -0700, Matthew Wilcox wrote:
>
> I'm a little disappointed to have received no feedback on these patches
> from those who were involved with creating the ugly situation in the
> first place.
>
> There are other ext4/f2fs patches in this patch series for which it
> would also be nice to get reviewed-by tags.
>
> ----- Forwarded message from Matthew Wilcox <willy@infradead.org> -----
>
> Date: Fri, 20 Mar 2020 07:22:19 -0700
> From: Matthew Wilcox <willy@infradead.org>
> To: Andrew Morton <akpm@linux-foundation.org>
> Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
> linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
> linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
> linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org,
> linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
> ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org, Christoph
> Hellwig <hch@lst.de>, William Kucharski <william.kucharski@oracle.com>
> Subject: [PATCH v9 13/25] mm: Add page_cache_readahead_unbounded
> X-Mailer: git-send-email 2.21.1
>
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>
> ext4 and f2fs have duplicated the guts of the readahead code so
> they can read past i_size. Instead, separate out the guts of the
> readahead code so they can call it directly.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: William Kucharski <william.kucharski@oracle.com>
I actually did look at this patch last month and it looked fine. Thanks for
doing this.
To be clear, we'd be fine with maintaining filesystem-specific code that does
the setup necessary to call ext4_mpage_readpages() and f2fs_mpage_readpages()
properly. And that was the original intent, so that nothing would leak into the
VFS. But I understand that the new readahead calling convention is different
and a bit more complex, and it's annoying to have multiple callers. So if
page_cache_readahead_unbounded() makes things easier for you, it's fine with me.
I'll take a closer look at your v9 series today and provide Reviewed-by on this
patch and others. Sorry for not doing so earlier.
Thanks!
- Eric
prev parent reply other threads:[~2020-03-20 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 14:29 Fwd: Add page_cache_readahead_unbounded Matthew Wilcox
2020-03-20 15:49 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320154947.GA851@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).