linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Sasha Levin <sashal@kernel.org>
Cc: Ritesh Harjani <ritesh.list@gmail.com>,
	stable@vger.kernel.org, "Theodore Y. Ts'o" <tytso@mit.edu>,
	linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>
Subject: Re: [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize
Date: Tue, 12 May 2020 18:12:05 +0200	[thread overview]
Message-ID: <20200512161205.GA690441@kroah.com> (raw)
In-Reply-To: <20200512141312.GP13035@sasha-vm>

On Tue, May 12, 2020 at 10:13:12AM -0400, Sasha Levin wrote:
> On Tue, May 12, 2020 at 02:59:31PM +0200, Greg KH wrote:
> > On Tue, May 12, 2020 at 06:20:05PM +0530, Ritesh Harjani wrote:
> > > Hello Greg,
> > > 
> > > On 5/12/20 5:15 PM, Greg KH wrote:
> > > > On Mon, May 11, 2020 at 01:37:59PM +0530, Ritesh Harjani wrote:
> > > > > Hello stable-list,
> > > > >
> > > > > I think this subjected patch [1] missed the below fixes tag.
> > > > > I guess the subjected patch is only picked for 5.7. And
> > > > > AFAIU, this patch will be needed for 5.6 as well.
> > > > >
> > > > > Could you please do the needful.
> > > > >
> > > > > Fixes: 244adf6426ee31a (ext4: make dioread_nolock the default)
> > > > >
> > > > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=626b035b816b61a7a7b4d2205a6807e2f11a18c1
> > > >
> > > > This patch does not apply to the 5.6 kernel tree at all.  Please provide
> > > > a working backport if you wish to see it present there.
> > > 
> > > Sorry if that's the case.
> > > I tried both "git cherry-pick" and "git am" with patch mentioned @ [1]
> > > to apply on branch "remotes/linux-stable/linux-5.6.y" of tree
> > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
> > > and it applied cleanly.
> > > 
> > > Also, just noticed this patch in the queue. Is it that maybe you are
> > > trying to apply it twice?
> > > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-5.6/ext4-don-t-set-dioread_nolock-by-default-for-blocksi.patch
> > 
> > Odd, it didn't have the "upstream" commit id, which is why I didn't see
> > that it was applied already.
> > 
> > Sasha, something went wrong with your scripts, you didn't sign-off on it
> > either :(
> 
> Crap, sorry. I'll fix it up.

I already did :)


      reply	other threads:[~2020-05-12 16:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18  3:47 Ext4 corruption with VM images as 3 > drop_caches Aneesh Kumar K.V
2020-03-19 13:24 ` Ritesh Harjani
2020-03-19 16:36 ` Jan Kara
2020-03-20  4:07   ` Aneesh Kumar K.V
2020-03-20  5:34 ` Ritesh Harjani
2020-03-20 11:49   ` Jan Kara
2020-03-21  3:22     ` Ritesh Harjani
2020-03-27 20:07 ` [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize Ritesh Harjani
2020-03-29  2:17   ` Theodore Y. Ts'o
2020-05-11  8:07     ` Ritesh Harjani
2020-05-12 11:45       ` Greg KH
2020-05-12 12:50         ` Ritesh Harjani
2020-05-12 12:59           ` Greg KH
2020-05-12 14:13             ` Sasha Levin
2020-05-12 16:12               ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512161205.GA690441@kroah.com \
    --to=greg@kroah.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=ritesh.list@gmail.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).