From: Eric Biggers <ebiggers@kernel.org>
To: linux-ext4@vger.kernel.org
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
stable@vger.kernel.org
Subject: Re: [PATCH] ext4: fix race between ext4_sync_parent() and rename()
Date: Thu, 21 May 2020 20:34:37 -0700 [thread overview]
Message-ID: <20200522033437.GA895@sol.localdomain> (raw)
In-Reply-To: <20200506183140.541194-1-ebiggers@kernel.org>
On Wed, May 06, 2020 at 11:31:40AM -0700, Eric Biggers wrote:
> /*
> * The directory inode may have gone through rmdir by now. But
> * the inode itself and its blocks are still allocated (we hold
> - * a reference to the inode so it didn't go through
> - * ext4_evict_inode()) and so we are safe to flush metadata
> - * blocks and the inode.
> + * a reference to the inode via its dentry), so it didn't go
> + * through ext4_evict_inode()) and so we are safe to flush
> + * metadata blocks and the inode.
> */
> ret = sync_mapping_buffers(inode->i_mapping);
Just realized that in this comment, the closing parenthesis I added after
"dentry" shouldn't be there. Ted, feel free to fix this if you're so inclined.
- Eric
prev parent reply other threads:[~2020-05-22 3:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 18:31 [PATCH] ext4: fix race between ext4_sync_parent() and rename() Eric Biggers
2020-05-09 12:30 ` Sasha Levin
2020-05-15 19:14 ` Eric Biggers
2020-05-22 3:34 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522033437.GA895@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).