Linux-ext4 Archive on lore.kernel.org
 help / color / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-ext4@vger.kernel.org, jack@suse.cz, adilger@dilger.ca,
	riteshh@linux.ibm.com, amir73il@gmail.com,
	linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org
Subject: Re: fiemap cleanups v4
Date: Sun, 24 May 2020 15:17:13 -0400
Message-ID: <20200524191713.GA228632@mit.edu> (raw)
In-Reply-To: <20200523155216.GZ23230@ZenIV.linux.org.uk>

On Sat, May 23, 2020 at 04:52:16PM +0100, Al Viro wrote:
> On Sat, May 23, 2020 at 09:30:07AM +0200, Christoph Hellwig wrote:
> > Hi all,
> > 
> > This series cleans up the fiemap support in ext4 and in general.
> > 
> > Ted or Al, can one of you pick this up?  It touches both ext4 and core
> > code, so either tree could work.
> > 
> > 
> > Changes since v3:
> >  - dropped the fixes that have been merged int mainline
> > 
> > Changes since v2:
> >  - commit message typo
> >  - doc updates
> >  - use d_inode in cifs
> >  - add a missing return statement in cifs
> >  - remove the filemap_write_and_wait call from ext4_ioctl_get_es_cache
> > 
> > Changes since v1:
> >  - rename fiemap_validate to fiemap_prep
> >  - lift FIEMAP_FLAG_SYNC handling to common code
> >  - add a new linux/fiemap.h header
> >  - remove __generic_block_fiemap
> >  - remove access_ok calls from fiemap and ext4
> 
> Hmmm...  I can do an immutable shared branch, no problem.  What would
> you prefer for a branchpoint for that one?

I thought we had already agreed to run these patches through the ext4
git tree, since most of the changes affect the ext4 tree (and there
aren't any other iomap fiemap changes pending as far as I know).

The v3 versions of these patches have been part of the ext4 dev tree
since May 19th.  Since the ext4 dev tree is rewinding, I can easily
update it fiemap-fixes patch to be on top of the first two patches
which Linus has already accepted, and then merge it into the ext4 dev
branch.

							- Ted


  parent reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-23  7:30 Christoph Hellwig
2020-05-23  7:30 ` [PATCH 1/9] ext4: split _ext4_fiemap Christoph Hellwig
2020-05-23  7:30 ` [PATCH 2/9] ext4: remove the call to fiemap_check_flags in ext4_fiemap Christoph Hellwig
2020-05-23  7:30 ` [PATCH 3/9] fs: mark __generic_block_fiemap static Christoph Hellwig
2020-05-23  7:30 ` [PATCH 4/9] fs: move the fiemap definitions out of fs.h Christoph Hellwig
2020-05-23  7:30 ` [PATCH 5/9] iomap: fix the iomap_fiemap prototype Christoph Hellwig
2020-05-23  7:30 ` [PATCH 6/9] fs: move fiemap range validation into the file systems instances Christoph Hellwig
2020-05-26 16:25   ` Darrick J. Wong
2020-05-23  7:30 ` [PATCH 7/9] fs: handle FIEMAP_FLAG_SYNC in fiemap_prep Christoph Hellwig
2020-05-23  7:30 ` [PATCH 8/9] fs: remove the access_ok() check in ioctl_fiemap Christoph Hellwig
2020-05-23  7:30 ` [PATCH 9/9] ext4: remove the access_ok() check in ext4_ioctl_get_es_cache Christoph Hellwig
2020-05-23 15:52 ` fiemap cleanups v4 Al Viro
2020-05-24 11:57   ` Christoph Hellwig
2020-05-24 19:17   ` Theodore Y. Ts'o [this message]
2020-05-25  6:52     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200524191713.GA228632@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=amir73il@gmail.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=riteshh@linux.ibm.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ext4 Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ext4/0 linux-ext4/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ext4 linux-ext4/ https://lore.kernel.org/linux-ext4 \
		linux-ext4@vger.kernel.org
	public-inbox-index linux-ext4

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ext4


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git