From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2 4/4] ext4: add inline encryption support
Date: Mon, 29 Jun 2020 11:44:24 -0700 [thread overview]
Message-ID: <20200629184424.GG20492@sol.localdomain> (raw)
In-Reply-To: <20200629120405.701023-5-satyat@google.com>
On Mon, Jun 29, 2020 at 12:04:05PM +0000, Satya Tangirala via Linux-f2fs-devel wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Wire up ext4 to support inline encryption via the helper functions which
> fs/crypto/ now provides. This includes:
>
> - Adding a mount option 'inlinecrypt' which enables inline encryption
> on encrypted files where it can be used.
>
> - Setting the bio_crypt_ctx on bios that will be submitted to an
> inline-encrypted file.
>
> Note: submit_bh_wbc() in fs/buffer.c also needed to be patched for
> this part, since ext4 sometimes uses ll_rw_block() on file data.
>
> - Not adding logically discontiguous data to bios that will be submitted
> to an inline-encrypted file.
>
> - Not doing filesystem-layer crypto on inline-encrypted files.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Co-developed-by: Satya Tangirala <satyat@google.com>
> Signed-off-by: Satya Tangirala <satyat@google.com>
This patch looks good to me. (I can't technically provide Reviewed-by because
I'm listed as the author.)
Ted and Andreas, can you take a look?
- Eric
prev parent reply other threads:[~2020-06-29 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 12:04 [PATCH v2 0/4] Inline Encryption Support for fscrypt Satya Tangirala
2020-06-29 12:04 ` [PATCH v2 1/4] fs: introduce SB_INLINECRYPT Satya Tangirala
2020-06-29 18:24 ` Eric Biggers
2020-06-29 12:04 ` [PATCH v2 2/4] fscrypt: add inline encryption support Satya Tangirala
2020-06-29 18:22 ` Eric Biggers
2020-06-29 12:04 ` [PATCH v2 3/4] f2fs: " Satya Tangirala
2020-06-29 18:53 ` Eric Biggers
2020-06-29 12:04 ` [PATCH v2 4/4] ext4: " Satya Tangirala
2020-06-29 18:44 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629184424.GG20492@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=satyat@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).