From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Yi Zhuang <zhuangyi1@huawei.com>,
tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] ext4: lost matching-pair of trace in ext4_unlink
Date: Wed, 8 Jul 2020 15:52:08 +0530 [thread overview]
Message-ID: <20200708102209.0399EA405C@b06wcsmtp001.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <20200629122621.129953-1-zhuangyi1@huawei.com>
On 6/29/20 5:56 PM, Yi Zhuang wrote:
> If dquot_initialize() return non-zero and trace of ext4_unlink_enter/exit
> enabled then the matching-pair of trace_exit will lost in log.
>
> v2:
> Change the new label to be "out_trace:", which makes it more clear that
> it is undoing the "trace" part of the code. At the same time, fix other
> similar problems in this function:
>
> bh = ext4_find_entry(dir, &dentry->d_name, &de, NULL);
> if (IS_ERR(bh))
> return PTR_ERR(bh);
> if (!bh)
> goto end_unlink;
>
> According to Andreas' suggestion, split up the "end_unlink:" label becomes
> two separate labels, and then remove the "if (handle)" check, and then
> use out_bh: before the handle is started.
>
> Signed-off-by: Yi Zhuang <zhuangyi1@huawei.com>
Nice cleanup. Feel free to add:
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
next prev parent reply other threads:[~2020-07-08 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 12:26 [PATCH v2] ext4: lost matching-pair of trace in ext4_unlink Yi Zhuang
2020-06-29 19:22 ` Andreas Dilger
2020-07-08 10:22 ` Ritesh Harjani [this message]
2020-08-06 4:56 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708102209.0399EA405C@b06wcsmtp001.portsmouth.uk.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=zhuangyi1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).