From: Jan Kara <jack@suse.cz>
To: Keyur Patel <iamkeyur96@gmail.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix spelling mistakes in extents.c
Date: Wed, 8 Jul 2020 15:44:46 +0200 [thread overview]
Message-ID: <20200708134446.GA5288@quack2.suse.cz> (raw)
In-Reply-To: <20200611031947.165079-1-iamkeyur96@gmail.com>
On Wed 10-06-20 23:19:46, Keyur Patel wrote:
> Fix spelling issues over the comments in the code.
>
> requsted ==> requested
> deterimined ==> determined
> insde ==> inside
> neet ==> need
> somthing ==> something
>
> Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
Thanks. The fixes look good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Ted, I think this patch has fallen through the cracks...
Honza
> ---
> fs/ext4/extents.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 7d088ff1e902..8028e1aae8de 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -1915,7 +1915,7 @@ static unsigned int ext4_ext_check_overlap(struct ext4_sb_info *sbi,
>
> /*
> * ext4_ext_insert_extent:
> - * tries to merge requsted extent into the existing extent or
> + * tries to merge requested extent into the existing extent or
> * inserts requested extent as new one into the tree,
> * creating new leaf in the no-space case.
> */
> @@ -3125,7 +3125,7 @@ static int ext4_ext_zeroout(struct inode *inode, struct ext4_extent *ex)
> *
> *
> * Splits extent [a, b] into two extents [a, @split) and [@split, b], states
> - * of which are deterimined by split_flag.
> + * of which are determined by split_flag.
> *
> * There are two cases:
> * a> the extent are splitted into two extent.
> @@ -3650,7 +3650,7 @@ static int ext4_split_convert_extents(handle_t *handle,
> eof_block = map->m_lblk + map->m_len;
> /*
> * It is safe to convert extent to initialized via explicit
> - * zeroout only if extent is fully insde i_size or new_size.
> + * zeroout only if extent is fully inside i_size or new_size.
> */
> depth = ext_depth(inode);
> ex = path[depth].p_ext;
> @@ -4495,7 +4495,7 @@ static long ext4_zero_range(struct file *file, loff_t offset,
> }
>
> /*
> - * Round up offset. This is not fallocate, we neet to zero out
> + * Round up offset. This is not fallocate, we need to zero out
> * blocks, so convert interior block aligned part of the range to
> * unwritten and possibly manually zero out unaligned parts of the
> * range.
> @@ -5579,7 +5579,7 @@ ext4_swap_extents(handle_t *handle, struct inode *inode1,
> }
> ex1 = path1[path1->p_depth].p_ext;
> ex2 = path2[path2->p_depth].p_ext;
> - /* Do we have somthing to swap ? */
> + /* Do we have something to swap ? */
> if (unlikely(!ex2 || !ex1))
> goto finish;
>
> --
> 2.26.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-07-08 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 3:19 [PATCH] ext4: fix spelling mistakes in extents.c Keyur Patel
2020-07-08 13:44 ` Jan Kara [this message]
2020-07-29 20:12 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708134446.GA5288@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=iamkeyur96@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).