From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Jan Kara <jack@suse.cz>, Ted Tso <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, Wolfgang Frisch <wolfgang.frisch@suse.com>
Subject: Re: [PATCH] ext4: catch integer overflow in ext4_cache_extents
Date: Mon, 13 Jul 2020 19:14:47 +0530 [thread overview]
Message-ID: <20200713134448.4CFA3A4051@d06av23.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <20200713125818.21918-1-jack@suse.cz>
On 7/13/20 6:28 PM, Jan Kara wrote:
> From: Wolfgang Frisch <wolfgang.frisch@suse.com>
>
> When extent tree is corrupted we can hit BUG_ON in
> ext4_es_cache_extent(). Check for this and abort caching instead of
> crashing the machine.
Was it intentionally made corrupted by crafting a corrupted disk image?
Are there more such logic in place which checks for such corruption at
other places? Maybe a background over the issue which you saw may help.
Also how did it recover out of it?
Do you think it make sense to still emit a WARN_ON() here and then
return which warns that this could possibly a corrupted extent
entry? (maybe WARN_ON_ONCE() or via some ratelimiting if multiple extent
entries are corrupted for that inode).
-ritesh
next prev parent reply other threads:[~2020-07-13 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 12:58 [PATCH] ext4: catch integer overflow in ext4_cache_extents Jan Kara
2020-07-13 13:44 ` Ritesh Harjani [this message]
2020-07-14 12:31 ` Jan Kara
2020-07-15 11:53 ` Jan Kara
2020-07-15 17:25 ` Wolfgang Frisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713134448.4CFA3A4051@d06av23.portsmouth.uk.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wolfgang.frisch@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).