From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA47C433E1 for ; Tue, 21 Jul 2020 15:30:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7F37206E9 for ; Tue, 21 Jul 2020 15:30:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="iPSG9+Um" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728609AbgGUPaM (ORCPT ); Tue, 21 Jul 2020 11:30:12 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:40168 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726830AbgGUPaM (ORCPT ); Tue, 21 Jul 2020 11:30:12 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06LFHUKa161225; Tue, 21 Jul 2020 15:29:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=0Di/+LBNYrIXXMbvu11QntF17nf+IJYoGWc+LBb2pmg=; b=iPSG9+Umz/nYx5BTW0gSzz+8mMxfsHpGKGhyVNlQbirZ2Gg91F/+/yN9dorrb5yh4A2g FmIklwjq2cklliAWhg30YUoun8Nn9PSp+Ph/jMojQML7T17XWB74ao14KiXyExCDpFGU M+u+uc8e+c+26KhG2kaG1bwtxr7PfbZMSD3P3RTZoKpisxyoTEpaqFZg8VybrK0fuJHK VXExccYpeAA6f06W8iSHmKN9YlmqV5cWtDq4LR5U9VseAsoC5zhplcJyFIujM3Sd7hdy ZogK5xGO6PYcqsB86jqEIDXS8GQ018CRsRJ8Y3UjcATfZI6UKHSojn9GFiWRj17EH2hp 4Q== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 32bs1mdxg9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 21 Jul 2020 15:29:59 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06LFN2oV044772; Tue, 21 Jul 2020 15:27:59 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 32dyj646hs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jul 2020 15:27:58 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 06LFRuxF032038; Tue, 21 Jul 2020 15:27:56 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 21 Jul 2020 08:27:56 -0700 Date: Tue, 21 Jul 2020 08:27:54 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Matthew Wilcox , Goldwyn Rodrigues , Dave Chinner , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, Michael Kerrisk , linux-man@vger.kernel.org Subject: Re: RFC: iomap write invalidation Message-ID: <20200721152754.GD7597@magnolia> References: <20200713074633.875946-1-hch@lst.de> <20200720215125.bfz7geaftocy4r5l@fiona> <20200721145313.GA9217@lst.de> <20200721150432.GH15516@casper.infradead.org> <20200721150615.GA10330@lst.de> <20200721151437.GI15516@casper.infradead.org> <20200721151616.GA11074@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721151616.GA11074@lst.de> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9689 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=1 mlxscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007210111 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9689 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 bulkscore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 clxscore=1011 spamscore=0 mlxscore=0 impostorscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007210111 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jul 21, 2020 at 05:16:16PM +0200, Christoph Hellwig wrote: > On Tue, Jul 21, 2020 at 04:14:37PM +0100, Matthew Wilcox wrote: > > On Tue, Jul 21, 2020 at 05:06:15PM +0200, Christoph Hellwig wrote: > > > On Tue, Jul 21, 2020 at 04:04:32PM +0100, Matthew Wilcox wrote: > > > > I thought you were going to respin this with EREMCHG changed to ENOTBLK? > > > > > > Oh, true. I'll do that ASAP. > > > > Michael, could we add this to manpages? > > Umm, no. -ENOTBLK is internal - the file systems will retry using > buffered I/O and the error shall never escape to userspace (or even the > VFS for that matter). It's worth dropping a comment somewhere that ENOTBLK is the desired "fall back to buffered" errcode, seeing as Dave and I missed that in XFS... --D