linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Shijie Luo <luoshijie1@huawei.com>, linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, jack@suse.cz
Subject: Re: [PATCH] ext4:remove some redundant function declarations
Date: Fri, 24 Jul 2020 08:28:14 +0530	[thread overview]
Message-ID: <20200724025815.789D952050@d06av21.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <20200724014747.15924-1-luoshijie1@huawei.com>



On 7/24/20 7:17 AM, Shijie Luo wrote:
> ext4 update feature functions do not exist now, remove these useless
> function declarations.
> 
> Signed-off-by: Shijie Luo <luoshijie1@huawei.com>

LGTM, feel free to add:
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>

> ---
>   fs/ext4/ext4.h | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 42f5060f3cdf..196b52c75422 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2924,12 +2924,6 @@ do {									\
> 
>   #endif
> 
> -extern int ext4_update_compat_feature(handle_t *handle, struct super_block *sb,
> -					__u32 compat);
> -extern int ext4_update_rocompat_feature(handle_t *handle,
> -					struct super_block *sb,	__u32 rocompat);
> -extern int ext4_update_incompat_feature(handle_t *handle,
> -					struct super_block *sb,	__u32 incompat);
>   extern ext4_fsblk_t ext4_block_bitmap(struct super_block *sb,
>   				      struct ext4_group_desc *bg);
>   extern ext4_fsblk_t ext4_inode_bitmap(struct super_block *sb,
> 

      reply	other threads:[~2020-07-24  2:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24  1:47 [PATCH] ext4:remove some redundant function declarations Shijie Luo
2020-07-24  2:58 ` Ritesh Harjani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724025815.789D952050@d06av21.portsmouth.uk.ibm.com \
    --to=riteshh@linux.ibm.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=luoshijie1@huawei.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).