Linux-ext4 Archive on lore.kernel.org
 help / color / Atom feed
* ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp()
@ 2020-07-27  1:54 brookxu
  2020-07-27  3:20 ` Ritesh Harjani
  2020-08-06 14:59 ` Theodore Ts'o
  0 siblings, 2 replies; 3+ messages in thread
From: brookxu @ 2020-07-27  1:54 UTC (permalink / raw)
  To: tytso, adilger.kernel; +Cc: linux-ext4, linux-kernel

Delete the invalid BUGON in ext4_mb_load_buddy_gfp(), the previous
code has already judged whether page is NULL.

Signed-off-by: Chunguang Xu <brookxu@tencent.com>
---
 fs/ext4/mballoc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 28a139f..9b1c3ad 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1279,9 +1279,6 @@ int ext4_mb_init_group(struct super_block *sb, ext4_group_t group, gfp_t gfp)
     e4b->bd_buddy_page = page;
     e4b->bd_buddy = page_address(page) + (poff * sb->s_blocksize);
 
-    BUG_ON(e4b->bd_bitmap_page == NULL);
-    BUG_ON(e4b->bd_buddy_page == NULL);
-
     return 0;
 
 err:
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp()
  2020-07-27  1:54 ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp() brookxu
@ 2020-07-27  3:20 ` Ritesh Harjani
  2020-08-06 14:59 ` Theodore Ts'o
  1 sibling, 0 replies; 3+ messages in thread
From: Ritesh Harjani @ 2020-07-27  3:20 UTC (permalink / raw)
  To: brookxu, tytso, adilger.kernel; +Cc: linux-ext4, linux-kernel



On 7/27/20 7:24 AM, brookxu wrote:
> Delete the invalid BUGON in ext4_mb_load_buddy_gfp(), the previous
> code has already judged whether page is NULL.
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>

Thanks for the patch. LGTM. Feel free to add.
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>

> ---
>   fs/ext4/mballoc.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 28a139f..9b1c3ad 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1279,9 +1279,6 @@ int ext4_mb_init_group(struct super_block *sb, ext4_group_t group, gfp_t gfp)
>       e4b->bd_buddy_page = page;
>       e4b->bd_buddy = page_address(page) + (poff * sb->s_blocksize);
>   
> -    BUG_ON(e4b->bd_bitmap_page == NULL);
> -    BUG_ON(e4b->bd_buddy_page == NULL);
> -
>       return 0;
>   
>   err:
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp()
  2020-07-27  1:54 ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp() brookxu
  2020-07-27  3:20 ` Ritesh Harjani
@ 2020-08-06 14:59 ` Theodore Ts'o
  1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2020-08-06 14:59 UTC (permalink / raw)
  To: brookxu; +Cc: adilger.kernel, linux-ext4, linux-kernel

On Mon, Jul 27, 2020 at 09:54:14AM +0800, brookxu wrote:
> Delete the invalid BUGON in ext4_mb_load_buddy_gfp(), the previous
> code has already judged whether page is NULL.
> 
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>

Applied, but I had to manually apply your patch since it was mangled
by your mailer.

It looks like the problem may have been caused by your using gmail;
please take a look at the file Documentation/process/email-clients.rst for some hints.

							- Ted

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27  1:54 ext4: delete the invalid BUGON in ext4_mb_load_buddy_gfp() brookxu
2020-07-27  3:20 ` Ritesh Harjani
2020-08-06 14:59 ` Theodore Ts'o

Linux-ext4 Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ext4/0 linux-ext4/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ext4 linux-ext4/ https://lore.kernel.org/linux-ext4 \
		linux-ext4@vger.kernel.org
	public-inbox-index linux-ext4

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ext4


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git