From: Jan Kara <jack@suse.cz>
To: luomeng <luomeng12@huawei.com>
Cc: Jan Kara <jack@suse.cz>, Ted Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Lukas Czerner <lczerner@redhat.com>
Subject: Re: [PATCH 3/6] ext4: Check journal inode extents more carefully
Date: Tue, 28 Jul 2020 14:56:42 +0200 [thread overview]
Message-ID: <20200728125642.GA23568@quack2.suse.cz> (raw)
In-Reply-To: <ec26732c-d219-8219-e7d6-63dab7aee03d@huawei.com>
On Tue 28-07-20 17:10:28, luomeng wrote:
> 在 2020/7/27 19:44, Jan Kara 写道:
> > -int ext4_data_block_valid(struct ext4_sb_info *sbi, ext4_fsblk_t start_blk,
> > +int ext4_inode_block_valid(struct inode *inode, ext4_fsblk_t start_blk,
> > unsigned int count)
> > {
> > struct ext4_system_blocks *system_blks;
> > @@ -344,8 +346,8 @@ int ext4_data_block_valid(struct ext4_sb_info *sbi, ext4_fsblk_t start_blk,
> > */
> > rcu_read_lock();
> > system_blks = rcu_dereference(sbi->system_blks);
> Because of a change in the function parameters，there is no 'sbi' declared.
> So there will be a compile error:
>
> fs/ext4/block_validity.c: In function ‘ext4_inode_block_valid’:
> fs/ext4/block_validity.c:345:32: error: ‘sbi’ undeclared (first use
> in this function)
> system_blks = rcu_dereference(sbi->system_blks);
Hum, right. It gets fixed up in the following patch but since this patch is
marked for stable, we better fix it. Thanks for noticing!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-07-28 12:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 11:44 [PATCH 0/6 v2] ext4: Check journal inode extents more carefully Jan Kara
2020-07-27 11:44 ` [PATCH 1/6] ext4: Handle error of ext4_setup_system_zone() on remount Jan Kara
2020-07-27 11:44 ` [PATCH 2/6] ext4: Don't allow overlapping system zones Jan Kara
2020-07-27 11:44 ` [PATCH 3/6] ext4: Check journal inode extents more carefully Jan Kara
2020-07-28 9:10 ` luomeng
2020-07-28 12:56 ` Jan Kara [this message]
2020-07-27 11:44 ` [PATCH 4/6] ext4: Fold ext4_data_block_valid_rcu() into the caller Jan Kara
2020-07-27 11:44 ` [PATCH 5/6] ext4: Handle add_system_zone() failure in ext4_setup_system_zone() Jan Kara
2020-07-27 12:39 ` Lukas Czerner
2020-07-27 11:44 ` [PATCH 6/6] ext4: Correctly restore system zone info when remount fails Jan Kara
2020-07-27 12:43 ` Lukas Czerner
2020-07-28 13:04 [PATCH 0/6 v3] ext4: Check journal inode extents more carefully Jan Kara
2020-07-28 13:04 ` [PATCH 3/6] " Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728125642.GA23568@quack2.suse.cz \
--to=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=luomeng12@huawei.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).