From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE7AC4727F for ; Wed, 23 Sep 2020 10:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD19921BE5 for ; Wed, 23 Sep 2020 10:35:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbgIWKfd (ORCPT ); Wed, 23 Sep 2020 06:35:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:46414 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgIWKfc (ORCPT ); Wed, 23 Sep 2020 06:35:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DE028AC79; Wed, 23 Sep 2020 10:36:08 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 578261E12E3; Wed, 23 Sep 2020 12:35:31 +0200 (CEST) Date: Wed, 23 Sep 2020 12:35:31 +0200 From: Jan Kara To: Hui Su Cc: tytso@mit.edu, jack@suse.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] FIX the comment of struct jbd2_journal_handle Message-ID: <20200923103531.GE6719@quack2.suse.cz> References: <20200922171231.GA53120@rlk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200922171231.GA53120@rlk> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed 23-09-20 01:12:31, Hui Su wrote: > the struct name was modified long ago, but the comment still > use struct handle_s. > > Signed-off-by: Hui Su Thanks for the patch. It looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > include/linux/jbd2.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h > index 08f904943ab2..a1ef05412acf 100644 > --- a/include/linux/jbd2.h > +++ b/include/linux/jbd2.h > @@ -452,8 +452,8 @@ struct jbd2_inode { > struct jbd2_revoke_table_s; > > /** > - * struct handle_s - The handle_s type is the concrete type associated with > - * handle_t. > + * struct jbd2_journal_handle - The jbd2_journal_handle type is the concrete > + * type associated with handle_t. > * @h_transaction: Which compound transaction is this update a part of? > * @h_journal: Which journal handle belongs to - used iff h_reserved set. > * @h_rsv_handle: Handle reserved for finishing the logical operation. > -- > 2.25.1 > > -- Jan Kara SUSE Labs, CR