From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/4] e2fsck: use size_t instead of int in string_copy()
Date: Thu, 1 Oct 2020 16:43:28 -0400 [thread overview]
Message-ID: <20201001204328.GO23474@mit.edu> (raw)
In-Reply-To: <20200605081442.13428-2-lczerner@redhat.com>
On Fri, Jun 05, 2020 at 10:14:40AM +0200, Lukas Czerner wrote:
> len argument in string_copy() is int, but it is used with malloc(),
> strlen(), strncpy() and some callers use sizeof() to pass value in. So
> it really ought to be size_t rather than int. Fix it.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2020-10-01 20:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 8:14 [PATCH 1/4] e2fsck: remove unused variable 'new_array' Lukas Czerner
2020-06-05 8:14 ` [PATCH 2/4] e2fsck: use size_t instead of int in string_copy() Lukas Czerner
2020-06-05 21:26 ` Andreas Dilger
2020-10-01 20:43 ` Theodore Y. Ts'o [this message]
2020-06-05 8:14 ` [PATCH 3/4] e2fsck: use the right conversion specifier in e2fsck_allocate_memory() Lukas Czerner
2020-06-05 20:42 ` Andreas Dilger
2020-10-01 20:49 ` Theodore Y. Ts'o
2020-06-05 8:14 ` [PATCH 4/4] ext2fs: remove unused variable 'left' Lukas Czerner
2020-06-05 20:48 ` Andreas Dilger
2020-10-01 20:51 ` Theodore Y. Ts'o
2020-06-05 20:36 ` [PATCH 1/4] e2fsck: remove unused variable 'new_array' Andreas Dilger
2020-06-05 20:38 ` Andreas Dilger
2020-09-22 12:37 ` Lukas Czerner
2020-10-01 20:43 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001204328.GO23474@mit.edu \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).