From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Cc: yi.zhang@huawei.com, jack@suse.cz, linux-ext4@vger.kernel.org,
adilger.kernel@dilger.ca
Subject: Re: [PATCH v3] ext4: Fix bdev write error check failed when mount fs with ro
Date: Sat, 3 Oct 2020 01:09:29 -0400 [thread overview]
Message-ID: <20201003050929.GL23474@mit.edu> (raw)
In-Reply-To: <20200928020556.710971-1-zhangxiaoxu5@huawei.com>
On Sun, Sep 27, 2020 at 10:05:56PM -0400, Zhang Xiaoxu wrote:
> Consider a situation when a filesystem was uncleanly shutdown and the
> orphan list is not empty and a read-only mount is attempted. The orphan
> list cleanup during mount will fail with:
>
> ext4_check_bdev_write_error:193: comm mount: Error while async write back metadata
>
> This happens because sbi->s_bdev_wb_err is not initialized when mounting
> the filesystem in read only mode and so ext4_check_bdev_write_error()
> falsely triggers.
>
> Initialize sbi->s_bdev_wb_err unconditionally to avoid this problem.
>
> Fixes: bc71726c7257 ("ext4: abort the filesystem if failed to async write metadata buffer")
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2020-10-03 5:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 2:05 [PATCH v3] ext4: Fix bdev write error check failed when mount fs with ro Zhang Xiaoxu
2020-10-03 5:09 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201003050929.GL23474@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).