From: Josh Triplett <josh@joshtriplett.org>
To: Andreas Dilger <adilger@dilger.ca>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Jan Kara <jack@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: ext4 regression in v5.9-rc2 from e7bfb5c9bb3d on ro fs with overlapped bitmaps
Date: Thu, 8 Oct 2020 15:28:05 -0700 [thread overview]
Message-ID: <20201008222805.GB45658@localhost> (raw)
In-Reply-To: <FEB46ECD-BE83-41E7-B765-ACD310823BB3@dilger.ca>
On Thu, Oct 08, 2020 at 01:25:57PM -0600, Andreas Dilger wrote:
> On Oct 8, 2020, at 1:12 PM, Josh Triplett <josh@joshtriplett.org> wrote:
> > On Wed, Oct 07, 2020 at 08:57:12PM -0600, Andreas Dilger wrote:
> >> I *do* think that inline_data is an under-appreciated feature that I
> >> would be happy to see some improvements with. I don't think that small
> >> files are a niche use case, and if we can clean up the inline_data code
> >> to work with 128-byte inodes I'm not against that, even though I'm not
> >> going to use that combination of features myself.
> >
> > I'd love to see that happen. At the time, it seemed like too large of a
> > change to block on, which is why I ended up deciding to switch to
> > 256-byte inodes.
>
> Does that mean you are using inline_data with 256-byte inodes?
I am, yes, and it mostly works great. I've hit zero issues with it in
the filesystems I'm generating.
> That would also be good to know, since there haven't been any
> well-known users of this feature so far (AFAIK). Since you are using
> this in a read-only manner, you won't hit the one know issue when an
> inline_data inode is extended to use an external block that may
> temporarily leave the inode in an inconsistent state.
I've run into a few other issues with it in other tools, as well. mke2fs
with inline_data generates invalid files given xattrs:
https://lore.kernel.org/linux-ext4/20200926102512.GA11386@localhost/T/#u
And extlinux doesn't like inline_data at all:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=971002
I'll report any other issues I run into using inline_data. I agree that
it's deeply underappreciated.
- Josh
prev parent reply other threads:[~2020-10-08 22:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHk-=wj-H5BYCU_kKiOK=B9sN3BtRzL4pnne2AJPyf54nQ+d=w@mail.gmail.com>
2020-10-05 8:14 ` ext4 regression in v5.9-rc2 from e7bfb5c9bb3d on ro fs with overlapped bitmaps Josh Triplett
2020-10-05 9:46 ` Jan Kara
2020-10-05 10:16 ` Josh Triplett
2020-10-05 16:19 ` Jan Kara
2020-10-05 16:20 ` Jan Kara
2020-10-05 17:36 ` Darrick J. Wong
2020-10-06 0:04 ` Theodore Y. Ts'o
2020-10-06 0:32 ` Josh Triplett
2020-10-06 2:51 ` Darrick J. Wong
2020-10-06 3:18 ` Theodore Y. Ts'o
2020-10-06 5:03 ` Josh Triplett
2020-10-06 6:03 ` Josh Triplett
2020-10-06 13:35 ` Theodore Y. Ts'o
2020-10-07 8:03 ` Josh Triplett
2020-10-07 14:32 ` Theodore Y. Ts'o
2020-10-07 20:14 ` Josh Triplett
2020-10-08 2:10 ` Theodore Y. Ts'o
2020-10-08 17:54 ` Darrick J. Wong
2020-10-08 22:38 ` Josh Triplett
2020-10-09 2:54 ` Darrick J. Wong
2020-10-09 19:08 ` Josh Triplett
2020-10-08 22:22 ` Josh Triplett
2020-10-09 14:37 ` Theodore Y. Ts'o
2020-10-09 20:30 ` Josh Triplett
2021-01-10 18:41 ` Malicious fs images was " Pavel Machek
2021-01-11 18:51 ` Darrick J. Wong
2021-01-11 19:39 ` Eric Biggers
2021-01-12 21:43 ` Theodore Ts'o
2021-01-12 22:28 ` Pavel Machek
2021-01-13 5:09 ` Theodore Ts'o
2020-10-08 2:57 ` Andreas Dilger
2020-10-08 19:12 ` Josh Triplett
2020-10-08 19:25 ` Andreas Dilger
2020-10-08 22:28 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008222805.GB45658@localhost \
--to=josh@joshtriplett.org \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).