From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Ritesh Harjani <riteshh@linux.ibm.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
jack@suse.cz, anju@linux.vnet.ibm.com,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>
Subject: Re: [PATCH 1/1] ext4: Fix bs < ps issue reported with dioread_nolock mount opt
Date: Fri, 9 Oct 2020 11:58:43 -0400 [thread overview]
Message-ID: <20201009155843.GL235506@mit.edu> (raw)
In-Reply-To: <CA+icZUXLDGfHVGJXp2dA2JAxP8LUV4EVDNJmz20YjHa5A9oTtQ@mail.gmail.com>
On Fri, Oct 09, 2020 at 12:18:23PM +0200, Sedat Dilek wrote:
> > > Fixes: tag should be 12 digits (see [1]).
> > > ( Seen while walking through ext-dev Git commits. )
> >
> > Thanks Sedat, I guess it should be minimum 12 chars [1]
Right, the point is that the commit ID referenced should be at least
12 bytes to avoid ambiguity. There's nothing really wrong with using
more than 12 bytes. I sometimes use 16, myself. It does look like
there is a (mostly harmless) inconsistency between lines 177 and 183
of submitting-patches.rst.
> In my ~/.gitconfig:
>
> [core]
> abbrev = 12
>
> # Check for 'Fixes:' tag used in the Linux-kernel development process
> (Thanks Kalle Valo).2
> # Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst
> # Usage: $ git log --format=fixes | head -5
> [pretty]
> fixes = Fixes: %h (\"%s\")
>
> Hope this is useful for others.
Personally, I find cutting and pasting the full SHA-1 hash and
description, and then cutting down the hash in emacs to be more
convenient, since I generaslly have the git commit from "git log" in
terminal window anyway. But whatever works for each developer. :-)
- Ted
prev parent reply other threads:[~2020-10-09 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 15:02 [PATCH 1/1] ext4: Fix bs < ps issue reported with dioread_nolock mount opt Ritesh Harjani
2020-10-08 16:04 ` Jan Kara
2020-10-09 6:46 ` Sedat Dilek
2020-10-09 7:18 ` Ritesh Harjani
2020-10-09 10:18 ` Sedat Dilek
2020-10-09 10:28 ` Sedat Dilek
2020-10-09 15:58 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009155843.GL235506@mit.edu \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anju@linux.vnet.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).