From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7234BC433E7 for ; Fri, 9 Oct 2020 15:58:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DB3B22267 for ; Fri, 9 Oct 2020 15:58:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389298AbgJIP6v (ORCPT ); Fri, 9 Oct 2020 11:58:51 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:35487 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389135AbgJIP6v (ORCPT ); Fri, 9 Oct 2020 11:58:51 -0400 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 099FwhHJ008865 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 9 Oct 2020 11:58:44 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 73313420107; Fri, 9 Oct 2020 11:58:43 -0400 (EDT) Date: Fri, 9 Oct 2020 11:58:43 -0400 From: "Theodore Y. Ts'o" To: Sedat Dilek Cc: Ritesh Harjani , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, jack@suse.cz, anju@linux.vnet.ibm.com, "Aneesh Kumar K . V" Subject: Re: [PATCH 1/1] ext4: Fix bs < ps issue reported with dioread_nolock mount opt Message-ID: <20201009155843.GL235506@mit.edu> References: <22e5c5f9-c06b-5c49-d165-8f194aad107b@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Oct 09, 2020 at 12:18:23PM +0200, Sedat Dilek wrote: > > > Fixes: tag should be 12 digits (see [1]). > > > ( Seen while walking through ext-dev Git commits. ) > > > > Thanks Sedat, I guess it should be minimum 12 chars [1] Right, the point is that the commit ID referenced should be at least 12 bytes to avoid ambiguity. There's nothing really wrong with using more than 12 bytes. I sometimes use 16, myself. It does look like there is a (mostly harmless) inconsistency between lines 177 and 183 of submitting-patches.rst. > In my ~/.gitconfig: > > [core] > abbrev = 12 > > # Check for 'Fixes:' tag used in the Linux-kernel development process > (Thanks Kalle Valo).2 > # Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst > # Usage: $ git log --format=fixes | head -5 > [pretty] > fixes = Fixes: %h (\"%s\") > > Hope this is useful for others. Personally, I find cutting and pasting the full SHA-1 hash and description, and then cutting down the hash in emacs to be more convenient, since I generaslly have the git commit from "git log" in terminal window anyway. But whatever works for each developer. :-) - Ted