From: Jan Kara <jack@suse.cz>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Jan Kara <jack@suse.cz>, Ted Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] mke2fs.8: Improve valid block size documentation
Date: Thu, 15 Oct 2020 11:27:31 +0200 [thread overview]
Message-ID: <20201015092731.GC7037@quack2.suse.cz> (raw)
In-Reply-To: <43B157BB-33E4-4D82-8A09-0E1BCACC55D9@dilger.ca>
On Wed 14-10-20 18:56:13, Andreas Dilger wrote:
> On Oct 13, 2020, at 7:38 AM, Jan Kara <jack@suse.cz> wrote:
> >
> > Explain which valid block sizes mke2fs supports in more detail.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> Should this mention that the default block size is 4096 bytes for most
> filesystems?
That would be to the "heuristic" parts. Yes, I agree, I'll add that.
> It might mention e.g. ppc64 or aarch64 can use 64KB page size, but this
> is definitely an improvement already.
Yeah, I can add that to the "page size" part. But with these archs there's
a catch that page size can be configured in the kernel config so the
formulation will need to be a bit more careful. But I'll add something.
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Thanks! I'll send v2.
Honza
>
> > ---
> > misc/mke2fs.8.in | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
> > index e6bfc6d6fd2d..0814d216f3a4 100644
> > --- a/misc/mke2fs.8.in
> > +++ b/misc/mke2fs.8.in
> > @@ -207,10 +207,11 @@ manual page for more details.
> > .SH OPTIONS
> > .TP
> > .BI \-b " block-size"
> > -Specify the size of blocks in bytes. Valid block-size values are 1024,
> > -2048 and 4096 bytes per block. If omitted,
> > -block-size is heuristically determined by the filesystem size and
> > -the expected usage of the filesystem (see the
> > +Specify the size of blocks in bytes. Valid block-size values are powers of two
> > +from 1024 up to 65536 (however note that the kernel is able to mount only
> > +filesystems with block-size smaller or equal to the system page size - 4k on
> > +x86 systems). If omitted, block-size is heuristically determined by the
> > +filesystem size and the expected usage of the filesystem (see the
> > .B \-T
> > option). If
> > .I block-size
> > --
> > 2.16.4
> >
>
>
> Cheers, Andreas
>
>
>
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-10-15 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 13:38 [PATCH] mke2fs.8: Improve valid block size documentation Jan Kara
2020-10-15 0:56 ` Andreas Dilger
2020-10-15 9:27 ` Jan Kara [this message]
2020-12-15 18:50 ` Theodore Y. Ts'o
2020-12-16 10:22 ` Jan Kara
2020-12-16 10:22 Jan Kara
2021-01-21 23:26 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015092731.GC7037@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).