* [PATCH][next] ext4: remove redundant assignment of variable ex
@ 2020-10-21 13:23 Colin King
2020-12-03 14:18 ` Theodore Y. Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-10-21 13:23 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger, linux-ext4
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable ex is assigned a variable that is not being read, the assignment
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/ext4/extents.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 6b33b9c86b00..80fac488769c 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -5993,7 +5993,6 @@ int ext4_ext_replay_set_iblocks(struct inode *inode)
kfree(path);
break;
}
- ex = path2[path2->p_depth].p_ext;
for (i = 0; i <= max(path->p_depth, path2->p_depth); i++) {
cmp1 = cmp2 = 0;
if (i <= path->p_depth)
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] ext4: remove redundant assignment of variable ex
2020-10-21 13:23 [PATCH][next] ext4: remove redundant assignment of variable ex Colin King
@ 2020-12-03 14:18 ` Theodore Y. Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Y. Ts'o @ 2020-12-03 14:18 UTC (permalink / raw)
To: Colin King; +Cc: Andreas Dilger, linux-ext4, kernel-janitors, linux-kernel
On Wed, Oct 21, 2020 at 02:23:26PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable ex is assigned a variable that is not being read, the assignment
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-03 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-21 13:23 [PATCH][next] ext4: remove redundant assignment of variable ex Colin King
2020-12-03 14:18 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).