From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C52C83012 for ; Sat, 28 Nov 2020 22:55:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEC78221FD for ; Sat, 28 Nov 2020 22:55:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732484AbgK1Wze (ORCPT ); Sat, 28 Nov 2020 17:55:34 -0500 Received: from mail.hallyn.com ([178.63.66.53]:60772 "EHLO mail.hallyn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727070AbgK1Wzd (ORCPT ); Sat, 28 Nov 2020 17:55:33 -0500 Received: by mail.hallyn.com (Postfix, from userid 1001) id 65BD38AB; Sat, 28 Nov 2020 16:54:50 -0600 (CST) Date: Sat, 28 Nov 2020 16:54:50 -0600 From: "Serge E. Hallyn" To: Christian Brauner Cc: Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, John Johansen , James Morris , Mimi Zohar , Dmitry Kasatkin , Stephen Smalley , Casey Schaufler , Arnd Bergmann , Andreas Dilger , OGAWA Hirofumi , Geoffrey Thomas , Mrunal Patel , Josh Triplett , Andy Lutomirski , Theodore Tso , Alban Crequy , Tycho Andersen , David Howells , James Bottomley , Seth Forshee , =?iso-8859-1?Q?St=E9phane?= Graber , Aleksa Sarai , Lennart Poettering , "Eric W. Biederman" , smbarber@chromium.org, Phil Estes , Serge Hallyn , Kees Cook , Todd Kjos , Paul Moore , Jonathan Corbet , containers@lists.linux-foundation.org, fstests@vger.kernel.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-ext4@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH v3 00/38] idmapped mounts Message-ID: <20201128225450.GC22812@mail.hallyn.com> References: <20201128213527.2669807-1-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201128213527.2669807-1-christian.brauner@ubuntu.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Nov 28, 2020 at 10:34:49PM +0100, Christian Brauner wrote: > Hey everyone, Hey Christian, a general request. Argue with me if it seems misguided. When looking at a patch or a small hunk of code, these days, if a variable called 'ns' or 'user_ns' is seen passed to a function, it can be easy to assume which user_ns it is based on what you think would make sense, but if your assumption is wrong, your patch review will be wrong. Can we stick to a convention where we have maybe subj_userns - the userns of the task seeking some action obj_userns - the userns of the thing being acted on - task, superblock,... mnt_userns - the userns of a mountpoint through which an object is seen You're replacing a lot of such callers and callsites in this patchset, so this would be a great time to start doing that. -serge