From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34F45C64E8A for ; Tue, 1 Dec 2020 10:19:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD8F720809 for ; Tue, 1 Dec 2020 10:19:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388656AbgLAKTK (ORCPT ); Tue, 1 Dec 2020 05:19:10 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:50849 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388603AbgLAKTJ (ORCPT ); Tue, 1 Dec 2020 05:19:09 -0500 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kk2jb-00076u-2S; Tue, 01 Dec 2020 10:18:11 +0000 Date: Tue, 1 Dec 2020 11:18:06 +0100 From: Christian Brauner To: "Serge E. Hallyn" Cc: Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, John Johansen , James Morris , Mimi Zohar , Dmitry Kasatkin , Stephen Smalley , Casey Schaufler , Arnd Bergmann , Andreas Dilger , OGAWA Hirofumi , Geoffrey Thomas , Mrunal Patel , Josh Triplett , Andy Lutomirski , Theodore Tso , Alban Crequy , Tycho Andersen , David Howells , James Bottomley , Seth Forshee , =?utf-8?B?U3TDqXBoYW5l?= Graber , Aleksa Sarai , Lennart Poettering , "Eric W. Biederman" , smbarber@chromium.org, Phil Estes , Kees Cook , Todd Kjos , Paul Moore , Jonathan Corbet , containers@lists.linux-foundation.org, fstests@vger.kernel.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-ext4@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH v3 00/38] idmapped mounts Message-ID: <20201201101806.3gd4kj36kpg4dif3@wittgenstein> References: <20201128213527.2669807-1-christian.brauner@ubuntu.com> <20201128225450.GC22812@mail.hallyn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201128225450.GC22812@mail.hallyn.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Nov 28, 2020 at 04:54:50PM -0600, Serge Hallyn wrote: > On Sat, Nov 28, 2020 at 10:34:49PM +0100, Christian Brauner wrote: > > Hey everyone, > > Hey Christian, > > a general request. Argue with me if it seems misguided. > > When looking at a patch or a small hunk of code, these days, if a variable > called 'ns' or 'user_ns' is seen passed to a function, it can be easy to > assume which user_ns it is based on what you think would make sense, but if > your assumption is wrong, your patch review will be wrong. > > Can we stick to a convention where we have maybe > > subj_userns - the userns of the task seeking some action > obj_userns - the userns of the thing being acted on - task, superblock,... > mnt_userns - the userns of a mountpoint through which an object is seen > > You're replacing a lot of such callers and callsites in this patchset, so > this would be a great time to start doing that. Hey Serge, this makes a lot of sense. I'll convert all accesses to the vfsmount's userns we're introducing in this series to to mnt_userns at least. Christian