From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A70AC83011 for ; Tue, 1 Dec 2020 11:15:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5571E206D8 for ; Tue, 1 Dec 2020 11:15:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729836AbgLALPV (ORCPT ); Tue, 1 Dec 2020 06:15:21 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:53804 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727800AbgLALPV (ORCPT ); Tue, 1 Dec 2020 06:15:21 -0500 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kk3c9-0003hF-B7; Tue, 01 Dec 2020 11:14:33 +0000 Date: Tue, 1 Dec 2020 12:14:30 +0100 From: Christian Brauner To: Christoph Hellwig Cc: Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, John Johansen , James Morris , Mimi Zohar , Dmitry Kasatkin , Stephen Smalley , Casey Schaufler , Arnd Bergmann , Andreas Dilger , OGAWA Hirofumi , Geoffrey Thomas , Mrunal Patel , Josh Triplett , Andy Lutomirski , Theodore Tso , Alban Crequy , Tycho Andersen , David Howells , James Bottomley , Seth Forshee , =?utf-8?B?U3TDqXBoYW5l?= Graber , Aleksa Sarai , Lennart Poettering , "Eric W. Biederman" , smbarber@chromium.org, Phil Estes , Serge Hallyn , Kees Cook , Todd Kjos , Paul Moore , Jonathan Corbet , containers@lists.linux-foundation.org, fstests@vger.kernel.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-ext4@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH v3 33/38] ext4: support idmapped mounts Message-ID: <20201201111430.ojt45p4qzjzdab7x@wittgenstein> References: <20201128213527.2669807-1-christian.brauner@ubuntu.com> <20201128213527.2669807-34-christian.brauner@ubuntu.com> <20201201105445.GJ27730@lst.de> <20201201110219.7gykwbsij6ld45wb@wittgenstein> <20201201111320.GA31288@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201201111320.GA31288@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Dec 01, 2020 at 12:13:20PM +0100, Christoph Hellwig wrote: > On Tue, Dec 01, 2020 at 12:02:19PM +0100, Christian Brauner wrote: > > On Tue, Dec 01, 2020 at 11:54:45AM +0100, Christoph Hellwig wrote: > > > What is the reason for the config option? The only thing that it > > > controls is setting of a single flag. > > > > I wanted to be conservative and give users the option to disable this on > > their kernel. Would you prefer if I drop it? > > I don't think adding an option per file system scales in any way. If > there is some strong urge to disable the functionality (which I see no > reason for) we could add something like a global sysctl for all on-disk > file systems. Sounds reasonable. I'm dropping the config options. Christian