From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E858C433DB for ; Fri, 8 Jan 2021 09:11:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE0C122248 for ; Fri, 8 Jan 2021 09:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727795AbhAHJLb (ORCPT ); Fri, 8 Jan 2021 04:11:31 -0500 Received: from verein.lst.de ([213.95.11.211]:43163 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727449AbhAHJLb (ORCPT ); Fri, 8 Jan 2021 04:11:31 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 74A2768C65; Fri, 8 Jan 2021 10:10:48 +0100 (CET) Date: Fri, 8 Jan 2021 10:10:48 +0100 From: Christoph Hellwig To: Eric Biggers Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Theodore Ts'o , Christoph Hellwig Subject: Re: [PATCH 10/13] fs: clean up __mark_inode_dirty() a bit Message-ID: <20210108091048.GA2587@lst.de> References: <20210105005452.92521-1-ebiggers@kernel.org> <20210105005452.92521-11-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210105005452.92521-11-ebiggers@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jan 04, 2021 at 04:54:49PM -0800, Eric Biggers wrote: > + } else { > + /* > + * Else it's either I_DIRTY_PAGES, I_DIRTY_TIME, or nothing. > + * (We don't support setting both I_DIRTY_PAGES and I_DIRTY_TIME > + * in one call to __mark_inode_dirty().) > + */ > + dirtytime = flags & I_DIRTY_TIME; > + WARN_ON_ONCE(dirtytime && (flags != I_DIRTY_TIME)); No need for the inner braces here. Otherwise looks good: Reviewed-by: Christoph Hellwig