From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D6B7C433E6 for ; Fri, 8 Jan 2021 09:15:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 365322226A for ; Fri, 8 Jan 2021 09:15:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728005AbhAHJPV (ORCPT ); Fri, 8 Jan 2021 04:15:21 -0500 Received: from verein.lst.de ([213.95.11.211]:43180 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbhAHJPU (ORCPT ); Fri, 8 Jan 2021 04:15:20 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 63E6767373; Fri, 8 Jan 2021 10:14:37 +0100 (CET) Date: Fri, 8 Jan 2021 10:14:36 +0100 From: Christoph Hellwig To: Eric Biggers Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Theodore Ts'o , Christoph Hellwig Subject: Re: [PATCH 11/13] fs: add a lazytime_expired method Message-ID: <20210108091436.GC2587@lst.de> References: <20210105005452.92521-1-ebiggers@kernel.org> <20210105005452.92521-12-ebiggers@kernel.org> <20210107140228.GF12990@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jan 07, 2021 at 02:05:57PM -0800, Eric Biggers wrote: > The XFS developers might have a different opinion though, as they were the ones > who requested it originally: > > https://lore.kernel.org/r/20200312143445.GA19160@infradead.org > https://lore.kernel.org/r/20200325092057.GA25483@infradead.org > https://lore.kernel.org/r/20200325154759.GY29339@magnolia > https://lore.kernel.org/r/20200312223913.GL10776@dread.disaster.area > > Any thoughts from anyone about whether we should still introduce a separate > notification for lazytime expiration, vs. just using ->dirty_inode(I_DIRTY_SYNC) > with I_DIRTY_TIME in i_state? I still find the way ->dirty_inode is used very confusing, but with this series and Jan's first patch I think we have a good enough state for now and don't need to add a method just for XFS. I still think it might make sense to eventually revisit how file systems are notified about dirtying.