From: Jan Kara <jack@suse.cz>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Theodore Ts'o <tytso@mit.edu>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time()
Date: Mon, 11 Jan 2021 15:52:40 +0100 [thread overview]
Message-ID: <20210111145240.GC18475@quack2.suse.cz> (raw)
In-Reply-To: <20210109075903.208222-5-ebiggers@kernel.org>
On Fri 08-01-21 23:58:55, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> As was done for generic_update_time(), only pass I_DIRTY_TIME to
> __mark_inode_dirty() when the inode's timestamps were actually updated
> and lazytime is enabled. This avoids a weird edge case where
> I_DIRTY_TIME could be set in i_state when lazytime isn't enabled.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/fat/misc.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/fs/fat/misc.c b/fs/fat/misc.c
> index f1b2a1fc2a6a4..18a50a46b57f8 100644
> --- a/fs/fat/misc.c
> +++ b/fs/fat/misc.c
> @@ -329,22 +329,23 @@ EXPORT_SYMBOL_GPL(fat_truncate_time);
>
> int fat_update_time(struct inode *inode, struct timespec64 *now, int flags)
> {
> - int iflags = I_DIRTY_TIME;
> - bool dirty = false;
> + int dirty_flags = 0;
>
> if (inode->i_ino == MSDOS_ROOT_INO)
> return 0;
>
> - fat_truncate_time(inode, now, flags);
> - if (flags & S_VERSION)
> - dirty = inode_maybe_inc_iversion(inode, false);
> - if ((flags & (S_ATIME | S_CTIME | S_MTIME)) &&
> - !(inode->i_sb->s_flags & SB_LAZYTIME))
> - dirty = true;
> + if (flags & (S_ATIME | S_CTIME | S_MTIME)) {
> + fat_truncate_time(inode, now, flags);
> + if (inode->i_sb->s_flags & SB_LAZYTIME)
> + dirty_flags |= I_DIRTY_TIME;
> + else
> + dirty_flags |= I_DIRTY_SYNC;
> + }
> +
> + if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false))
> + dirty_flags |= I_DIRTY_SYNC;
>
> - if (dirty)
> - iflags |= I_DIRTY_SYNC;
> - __mark_inode_dirty(inode, iflags);
> + __mark_inode_dirty(inode, dirty_flags);
> return 0;
> }
> EXPORT_SYMBOL_GPL(fat_update_time);
> --
> 2.30.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-01-11 14:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 7:58 [PATCH v2 00/12] lazytime fix and cleanups Eric Biggers
2021-01-09 7:58 ` [PATCH v2 01/12] fs: fix lazytime expiration handling in __writeback_single_inode() Eric Biggers
2021-01-11 10:48 ` Christoph Hellwig
2021-01-11 14:46 ` Jan Kara
2021-01-09 7:58 ` [PATCH v2 02/12] fs: correctly document the inode dirty flags Eric Biggers
2021-01-11 14:48 ` Jan Kara
2021-01-09 7:58 ` [PATCH v2 03/12] fs: only specify I_DIRTY_TIME when needed in generic_update_time() Eric Biggers
2021-01-11 14:50 ` Jan Kara
2021-01-09 7:58 ` [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time() Eric Biggers
2021-01-11 10:52 ` Christoph Hellwig
2021-01-11 19:50 ` Eric Biggers
2021-01-12 5:21 ` Dave Chinner
2021-01-12 13:23 ` Christoph Hellwig
2021-01-11 14:52 ` Jan Kara [this message]
2021-01-09 7:58 ` [PATCH v2 05/12] fs: don't call ->dirty_inode for lazytime timestamp updates Eric Biggers
2021-01-11 14:54 ` Jan Kara
2021-01-09 7:58 ` [PATCH v2 06/12] fs: pass only I_DIRTY_INODE flags to ->dirty_inode Eric Biggers
2021-01-11 14:56 ` Jan Kara
2021-01-09 7:58 ` [PATCH v2 07/12] fs: clean up __mark_inode_dirty() a bit Eric Biggers
2021-01-11 14:59 ` Jan Kara
2021-01-09 7:58 ` [PATCH v2 08/12] fs: drop redundant check from __writeback_single_inode() Eric Biggers
2021-01-11 10:52 ` Christoph Hellwig
2021-01-11 15:00 ` Jan Kara
2021-01-09 7:59 ` [PATCH v2 09/12] fs: improve comments for writeback_single_inode() Eric Biggers
2021-01-11 10:53 ` Christoph Hellwig
2021-01-11 15:05 ` Jan Kara
2021-01-09 7:59 ` [PATCH v2 10/12] gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync() Eric Biggers
2021-01-11 15:06 ` Jan Kara
2021-01-09 7:59 ` [PATCH v2 11/12] ext4: simplify i_state checks in __ext4_update_other_inode_time() Eric Biggers
2021-01-11 10:53 ` Christoph Hellwig
2021-01-11 20:23 ` Eric Biggers
2021-01-12 13:25 ` Christoph Hellwig
2021-02-03 5:16 ` Theodore Ts'o
2021-01-11 15:11 ` Jan Kara
2021-01-09 7:59 ` [PATCH v2 12/12] xfs: remove a stale comment from xfs_file_aio_write_checks() Eric Biggers
2021-01-12 17:31 ` Darrick J. Wong
2021-01-11 15:15 ` [PATCH v2 00/12] lazytime fix and cleanups Jan Kara
2021-01-11 20:44 ` Eric Biggers
2021-02-03 5:11 ` Theodore Ts'o
2021-02-03 5:22 ` Eric Biggers
2021-02-03 15:49 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111145240.GC18475@quack2.suse.cz \
--to=jack@suse.cz \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).