* [PATCH resend] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it
@ 2021-01-22 11:02 Geert Uytterhoeven
2021-01-22 17:38 ` Randy Dunlap
2021-02-12 4:13 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-01-22 11:02 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger, Shuah Khan, Brendan Higgins,
Iurii Zaikin
Cc: Randy Dunlap, linux-ext4, linux-kernel, Geert Uytterhoeven
EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the
user may not want to enable. Fix this by making the test depend on
EXT4_FS instead.
Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Discussion after previous submission at
https://lore.kernel.org/linux-ext4/20201020073740.29081-1-geert@linux-m68k.org/
---
fs/ext4/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
index 619dd35ddd48a973..86699c8cab281cbc 100644
--- a/fs/ext4/Kconfig
+++ b/fs/ext4/Kconfig
@@ -103,8 +103,7 @@ config EXT4_DEBUG
config EXT4_KUNIT_TESTS
tristate "KUnit tests for ext4" if !KUNIT_ALL_TESTS
- select EXT4_FS
- depends on KUNIT
+ depends on EXT4_FS && KUNIT
default KUNIT_ALL_TESTS
help
This builds the ext4 KUnit tests.
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH resend] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it
2021-01-22 11:02 [PATCH resend] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it Geert Uytterhoeven
@ 2021-01-22 17:38 ` Randy Dunlap
2021-02-12 4:13 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-01-22 17:38 UTC (permalink / raw)
To: Geert Uytterhoeven, Theodore Ts'o, Andreas Dilger,
Shuah Khan, Brendan Higgins, Iurii Zaikin
Cc: linux-ext4, linux-kernel
On 1/22/21 3:02 AM, Geert Uytterhoeven wrote:
> EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the
> user may not want to enable. Fix this by making the test depend on
> EXT4_FS instead.
>
> Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> Discussion after previous submission at
> https://lore.kernel.org/linux-ext4/20201020073740.29081-1-geert@linux-m68k.org/
> ---
> fs/ext4/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
> index 619dd35ddd48a973..86699c8cab281cbc 100644
> --- a/fs/ext4/Kconfig
> +++ b/fs/ext4/Kconfig
> @@ -103,8 +103,7 @@ config EXT4_DEBUG
>
> config EXT4_KUNIT_TESTS
> tristate "KUnit tests for ext4" if !KUNIT_ALL_TESTS
> - select EXT4_FS
> - depends on KUNIT
> + depends on EXT4_FS && KUNIT
> default KUNIT_ALL_TESTS
> help
> This builds the ext4 KUnit tests.
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH resend] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it
2021-01-22 11:02 [PATCH resend] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it Geert Uytterhoeven
2021-01-22 17:38 ` Randy Dunlap
@ 2021-02-12 4:13 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2021-02-12 4:13 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Andreas Dilger, Shuah Khan, Brendan Higgins, Iurii Zaikin,
Randy Dunlap, linux-ext4, linux-kernel
On Fri, Jan 22, 2021 at 12:02:34PM +0100, Geert Uytterhoeven wrote:
> EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the
> user may not want to enable. Fix this by making the test depend on
> EXT4_FS instead.
>
> Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-12 4:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-22 11:02 [PATCH resend] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it Geert Uytterhoeven
2021-01-22 17:38 ` Randy Dunlap
2021-02-12 4:13 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).