From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Christoph Hellwig <hch@lst.de>, Theodore Ts'o <tytso@mit.edu>,
Eryu Guan <guan@eryu.me>, Christian Brauner <brauner@kernel.org>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
"Darrick J . Wong" <djwong@kernel.org>,
David Howells <dhowells@redhat.com>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH -RFC] ext4: add feature file to advertise that ext4 supports idmapped mounts
Date: Thu, 15 Apr 2021 09:55:37 +0200 [thread overview]
Message-ID: <20210415075537.GA12220@lst.de> (raw)
In-Reply-To: <20210415074921.cf5uv4xehlctvtvv@wittgenstein>
On Thu, Apr 15, 2021 at 09:49:21AM +0200, Christian Brauner wrote:
> However, as a general way of advertising to users that ext4 supports
> idmapped mounts I don't necessarily see a problem with that. It doesn't
> have implications for other filesystems and ext4 already advertises
> other features in a similar way.
I still think that is a very bad idea. idmapped mounts are foremost
a VFS feature, with just a tiny bit of glue in every file system that
does not affect the on-disk format. So any discovery for it needs
to be using VFS infrastructure. IMHO just trying to mount is the
proper way to do it, but if people want some other form of discovery
it needs to be something in generic code.
next prev parent reply other threads:[~2021-04-15 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210328223400.1800301-1-brauner@kernel.org>
[not found] ` <20210328223400.1800301-3-brauner@kernel.org>
[not found] ` <YHMH/JRmzg3ETcED@desktop>
[not found] ` <20210411151249.6y34x7yatqtpcvi6@wittgenstein>
[not found] ` <20210411151857.wd6gd46u53vlh2xv@wittgenstein>
[not found] ` <YHMUAL/oD4fB3+R7@desktop>
[not found] ` <20210411153223.vhcegiklrwoczy55@wittgenstein>
[not found] ` <YHOW7DN51YuYgLPM@mit.edu>
[not found] ` <20210412115426.a4bzsx4cp7jhx2ou@wittgenstein>
[not found] ` <YHTMkBcVTFAGqyks@mit.edu>
2021-04-14 20:47 ` [PATCH -RFC] ext4: add feature file to advertise that ext4 supports idmapped mounts Theodore Ts'o
2021-04-15 5:54 ` Christoph Hellwig
2021-04-15 7:49 ` Christian Brauner
2021-04-15 7:55 ` Christoph Hellwig [this message]
2021-04-15 8:13 ` Christian Brauner
2021-04-15 14:59 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415075537.GA12220@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).