From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: Lukas Czerner <lczerner@redhat.com>,
Theodore Ts'o <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>,
Jeff Layton <jlayton@kernel.org>
Subject: [PATCH v2 0/7] test_dummy_encryption fixes and cleanups
Date: Sat, 30 Apr 2022 22:08:50 -0700 [thread overview]
Message-ID: <20220501050857.538984-1-ebiggers@kernel.org> (raw)
This series cleans up and fixes the way that ext4 and f2fs handle the
test_dummy_encryption mount option:
- Patches 1-2 make test_dummy_encryption consistently require that the
'encrypt' feature flag already be enabled and that
CONFIG_FS_ENCRYPTION be enabled. Note, this will cause xfstest
ext4/053 to start failing; my xfstests patch "ext4/053: update the
test_dummy_encryption tests" will fix that.
- Patches 3-7 replace the fscrypt_set_test_dummy_encryption() helper
function with new functions that work properly with the new mount API,
by splitting up the parsing, checking, and applying steps. These fix
bugs that were introduced when ext4 started using the new mount API.
We can either take all these patches through the fscrypt tree, or we can
take them in multiple cycles as follows:
1. patch 1 via ext4, patch 2 via f2fs, patch 3-4 via fscrypt
2. patch 5 via ext4, patch 6 via f2fs
3. patch 7 via fscrypt
Ted and Jaegeuk, let me know what you prefer.
Changed v1 => v2:
- Added patches 2-7
- Also reject test_dummy_encryption when !CONFIG_FS_ENCRYPTION
Eric Biggers (7):
ext4: only allow test_dummy_encryption when supported
f2fs: reject test_dummy_encryption when !CONFIG_FS_ENCRYPTION
fscrypt: factor out fscrypt_policy_to_key_spec()
fscrypt: add new helper functions for test_dummy_encryption
ext4: fix up test_dummy_encryption handling for new mount API
f2fs: use the updated test_dummy_encryption helper functions
fscrypt: remove fscrypt_set_test_dummy_encryption()
fs/crypto/fscrypt_private.h | 6 +-
fs/crypto/keyring.c | 64 +++++++++++---
fs/crypto/keysetup.c | 20 +----
fs/crypto/policy.c | 121 +++++++++++++------------
fs/ext4/ext4.h | 6 --
fs/ext4/super.c | 172 ++++++++++++++++++++----------------
fs/f2fs/super.c | 28 ++++--
include/linux/fscrypt.h | 41 ++++++++-
8 files changed, 280 insertions(+), 178 deletions(-)
base-commit: 8013d1d3d2e33236dee13a133fba49ad55045e79
--
2.36.0
next reply other threads:[~2022-05-01 5:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 5:08 Eric Biggers [this message]
2022-05-01 5:08 ` [PATCH v2 1/7] ext4: only allow test_dummy_encryption when supported Eric Biggers
2022-05-11 12:50 ` Ritesh Harjani
2022-05-11 17:18 ` Eric Biggers
2022-05-01 5:08 ` [PATCH v2 2/7] f2fs: reject test_dummy_encryption when !CONFIG_FS_ENCRYPTION Eric Biggers
2022-05-01 5:08 ` [PATCH v2 3/7] fscrypt: factor out fscrypt_policy_to_key_spec() Eric Biggers
2022-05-01 5:08 ` [PATCH v2 4/7] fscrypt: add new helper functions for test_dummy_encryption Eric Biggers
2022-05-01 5:08 ` [PATCH v2 5/7] ext4: fix up test_dummy_encryption handling for new mount API Eric Biggers
2022-05-09 23:40 ` Eric Biggers
2022-05-11 17:54 ` [f2fs-dev] " Ritesh Harjani
2022-05-11 18:03 ` Eric Biggers
2022-05-13 10:58 ` Ritesh Harjani
2022-05-13 22:24 ` Eric Biggers
2022-05-13 11:07 ` Ritesh Harjani
2022-05-13 21:59 ` Eric Biggers
2022-05-01 5:08 ` [PATCH v2 6/7] f2fs: use the updated test_dummy_encryption helper functions Eric Biggers
2022-05-01 5:08 ` [PATCH v2 7/7] fscrypt: remove fscrypt_set_test_dummy_encryption() Eric Biggers
2022-05-09 23:36 ` [PATCH v2 0/7] test_dummy_encryption fixes and cleanups Eric Biggers
2022-05-10 23:23 ` Jaegeuk Kim
2022-05-13 19:36 ` Theodore Ts'o
2022-05-13 23:26 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220501050857.538984-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=jlayton@kernel.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).